Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 1726323002: Have Permission{Manager,Service} use Origin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clarify and test Origin.empty_. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/permissions/permission_context_base.cc ('K') | « chromecast/browser/cast_permission_manager.cc ('k') | content/browser/permissions/permission_service_context.h » ('j') | url/origin.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index 3b619f154c6fca9d60b09d3a99f30145ba36c663..2bde4bda783a8d6099b453ce165ac4611a014ef5 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -77,6 +77,7 @@
#include "ui/accessibility/ax_tree.h"
#include "ui/accessibility/ax_tree_update.h"
#include "url/gurl.h"
+#include "url/origin.h"
#if defined(OS_ANDROID)
#include "content/browser/mojo/service_registrar_android.h"
@@ -2513,10 +2514,11 @@ void RenderFrameHostImpl::DidUseGeolocationPermission() {
return;
permission_manager->RegisterPermissionUsage(
- PermissionType::GEOLOCATION,
- last_committed_url().GetOrigin(),
- frame_tree_node()->frame_tree()->GetMainFrame()
- ->last_committed_url().GetOrigin());
+ PermissionType::GEOLOCATION, url::Origin(last_committed_url()),
+ url::Origin(frame_tree_node()
+ ->frame_tree()
+ ->GetMainFrame()
+ ->last_committed_url()));
}
void RenderFrameHostImpl::UpdatePermissionsForNavigation(
« chrome/browser/permissions/permission_context_base.cc ('K') | « chromecast/browser/cast_permission_manager.cc ('k') | content/browser/permissions/permission_service_context.h » ('j') | url/origin.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698