chrome/browser/push_messaging/push_messaging_service_unittest.cc - Issue 1726323002: Have Permission{Manager,Service} use Origin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/push_messaging/push_messaging_service_unittest.cc

Issue 1726323002: Have Permission{Manager,Service} use Origin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clarify and test Origin.empty_. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/push_messaging/push_messaging_service_unittest.cc

diff --git a/chrome/browser/push_messaging/push_messaging_service_unittest.cc b/chrome/browser/push_messaging/push_messaging_service_unittest.cc

index a68e0d1c9d186c3601c48c7604694e797391892c..6b032893340dba535a0b46116381cfb9d6325c06 100644

--- a/chrome/browser/push_messaging/push_messaging_service_unittest.cc

+++ b/chrome/browser/push_messaging/push_messaging_service_unittest.cc

@@ -66,8 +66,8 @@ class FakePushMessagingPermissionContext

~FakePushMessagingPermissionContext() override {}

ContentSetting GetPermissionStatus(

- const GURL& requesting_origin,

- const GURL& embedding_origin) const override {

+ const url::Origin& requesting_origin,

+ const url::Origin& embedding_origin) const override {

return CONTENT_SETTING_ALLOW;

}

};