chrome/browser/background_sync/background_sync_permission_context_unittest.cc - Issue 1726323002: Have Permission{Manager,Service} use Origin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/background_sync/background_sync_permission_context_unittest.cc

Issue 1726323002: Have Permission{Manager,Service} use Origin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clarify and test Origin.empty_. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/background_sync/background_sync_permission_context.cc ('k') | chrome/browser/geolocation/geolocation_permission_context.h » ('j') | chrome/browser/permissions/permission_context_base.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/background_sync/background_sync_permission_context_unittest.cc

diff --git a/chrome/browser/background_sync/background_sync_permission_context_unittest.cc b/chrome/browser/background_sync/background_sync_permission_context_unittest.cc

index 62f9839d3f02517cac55bd02eb7428f4fb185931..550471c55a7e03b8511957f4929b7b5b4fc5efe3 100644

--- a/chrome/browser/background_sync/background_sync_permission_context_unittest.cc

+++ b/chrome/browser/background_sync/background_sync_permission_context_unittest.cc

@@ -21,6 +21,7 @@

#include "content/public/test/mock_render_process_host.h"

#include "content/public/test/web_contents_tester.h"

#include "testing/gtest/include/gtest/gtest.h"

+#include "url/origin.h"

class BackgroundSyncPermissionContextTest

: public ChromeRenderViewHostTestHarness {

@@ -40,7 +41,7 @@ class BackgroundSyncPermissionContextTest

web_contents()->GetRenderProcessHost()->GetID(),

web_contents()->GetMainFrame()->GetRoutingID(), -1 /* request_id */);

permission_context->RequestPermission(

- web_contents(), id, url,

+ web_contents(), id, url::Origin(url),

base::Bind(

&BackgroundSyncPermissionContextTest::TrackPermissionDecision,

base::Unretained(this), run_loop.QuitClosure()));