src/ports/SkFontMgr_android_parser.h - Issue 1726213004: Deduplicate axis value resolving code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ports/SkFontMgr_android_parser.h

Issue 1726213004: Deduplicate axis value resolving code. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Convince gcc that the values are assigned before use. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ports/SkFontMgr_android_parser.h

diff --git a/src/ports/SkFontMgr_android_parser.h b/src/ports/SkFontMgr_android_parser.h

index b841bc6d189d342de8029fa005b4b793b46e8953..efd8144f1463fa323f21e28efb073dacde82cce0 100644

--- a/src/ports/SkFontMgr_android_parser.h

+++ b/src/ports/SkFontMgr_android_parser.h

@@ -8,7 +8,7 @@

#ifndef SkFontMgr_android_parser_DEFINED

#define SkFontMgr_android_parser_DEFINED

-#include "SkFixed.h"

+#include "SkFontMgr.h"

#include "SkString.h"

#include "SkTArray.h"

#include "SkTDArray.h"

@@ -73,12 +73,7 @@ struct FontFileInfo {

int fIndex;

int fWeight;

enum class Style { kAuto, kNormal, kItalic } fStyle;

- struct Axis {

- Axis() : fTag(SkSetFourByteTag('\0','\0','\0','\0')), fValue(0) { }

- SkFourByteTag fTag;

- SkFixed fValue;

- };

- SkTArray<Axis, true> fAxes;

+ SkTArray<SkFontMgr::FontParameters::Axis, true> fAxes;

};

/**

« no previous file with comments | « src/ports/SkFontMgr_android.cpp ('k') | src/ports/SkFontMgr_android_parser.cpp » ('j') | no next file with comments »