Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Side by Side Diff: sdk/lib/_internal/compiler/implementation/tree/nodes.dart

Issue 17262003: Fix type variables in closures. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of tree; 5 part of tree;
6 6
7 abstract class Visitor<R> { 7 abstract class Visitor<R> {
8 const Visitor(); 8 const Visitor();
9 9
10 R visitNode(Node node); 10 R visitNode(Node node);
(...skipping 351 matching lines...) Expand 10 before | Expand all | Expand 10 after
362 bool get isCall => !isOperator && !isPropertyAccess; 362 bool get isCall => !isOperator && !isPropertyAccess;
363 bool get isIndex => 363 bool get isIndex =>
364 isOperator && identical(selector.asOperator().source.stringValue, '[]'); 364 isOperator && identical(selector.asOperator().source.stringValue, '[]');
365 bool get isLogicalAnd => 365 bool get isLogicalAnd =>
366 isOperator && identical(selector.asOperator().source.stringValue, '&&'); 366 isOperator && identical(selector.asOperator().source.stringValue, '&&');
367 bool get isLogicalOr => 367 bool get isLogicalOr =>
368 isOperator && identical(selector.asOperator().source.stringValue, '||'); 368 isOperator && identical(selector.asOperator().source.stringValue, '||');
369 bool get isParameterCheck => 369 bool get isParameterCheck =>
370 isOperator && identical(selector.asOperator().source.stringValue, '?'); 370 isOperator && identical(selector.asOperator().source.stringValue, '?');
371 371
372 bool get isTypeCast {
373 return isOperator
374 && identical(selector.asOperator().source.stringValue, 'as');
375 }
376
377 bool get isIsCheck {
378 return isOperator
379 && identical(selector.asOperator().source.stringValue, 'is')
380 && arguments.head.asSend() == null;
381 }
382
372 bool get isIsNotCheck { 383 bool get isIsNotCheck {
373 return isOperator 384 return isOperator
374 && identical(selector.asOperator().source.stringValue, 'is') 385 && identical(selector.asOperator().source.stringValue, 'is')
375 && arguments.head.asSend() != null; 386 && arguments.head.asSend() != null;
376 } 387 }
377 388
378 TypeAnnotation get typeAnnotationFromIsCheck { 389 TypeAnnotation get typeAnnotationFromIsCheck {
379 assert(isOperator 390 assert(isOperator
380 && identical(selector.asOperator().source.stringValue, 'is')); 391 && identical(selector.asOperator().source.stringValue, 'is'));
381 return isIsNotCheck 392 return isIsNotCheck
(...skipping 1718 matching lines...) Expand 10 before | Expand all | Expand 10 after
2100 * argument). 2111 * argument).
2101 * 2112 *
2102 * TODO(ahe): This method is controversial, the team needs to discuss 2113 * TODO(ahe): This method is controversial, the team needs to discuss
2103 * if top-level methods are acceptable and what naming conventions to 2114 * if top-level methods are acceptable and what naming conventions to
2104 * use. 2115 * use.
2105 */ 2116 */
2106 initializerDo(Node node, f(Node node)) { 2117 initializerDo(Node node, f(Node node)) {
2107 SendSet send = node.asSendSet(); 2118 SendSet send = node.asSendSet();
2108 if (send != null) return f(send.arguments.head); 2119 if (send != null) return f(send.arguments.head);
2109 } 2120 }
OLDNEW
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/builder.dart ('k') | tests/language/type_variable_closure_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698