Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1726173002: Treat Element.clientTop/Left/etc same as scrollTop/etc., avoid duplicate members (Closed)

Created:
4 years, 10 months ago by Alan Knight
Modified:
4 years, 10 months ago
Reviewers:
terry, Jacob
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Treat Element.clientTop/Left/etc same as scrollTop/etc., avoid duplicate members BUG= R=jacobr@google.com Committed: https://github.com/dart-lang/sdk/commit/cc142b92a4eac951e13562c954be0baea2506c35

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tools/dom/scripts/htmlrenamer.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Alan Knight
4 years, 10 months ago (2016-02-23 23:10:39 UTC) #2
Jacob
lgtm
4 years, 10 months ago (2016-02-23 23:19:21 UTC) #3
Alan Knight
Landing while tree is closed as doesn't impact build.
4 years, 10 months ago (2016-02-24 00:29:21 UTC) #4
Alan Knight
4 years, 10 months ago (2016-02-24 00:29:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cc142b92a4eac951e13562c954be0baea2506c35.

Powered by Google App Engine
This is Rietveld 408576698