Issue 1726163002: Fix building on musl libc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1726163002: Fix building on musl libc.

Created:
4 years, 10 months ago by Kylie McClain

Modified:
4 years, 9 months ago

Reviewers:

CC:
google-breakpad-dev_googlegroups.com

Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix building on musl libc. These are a few patches written by Felix Janda, originally submitted via Monorail at https://bugs.chromium.org/p/google-breakpad/issues/detail?id=631 along with one I wrote. I'd like to see these upstreamed sooner rather than later, and did not see them anywhere on codereview, so I took that as a goahead to submit these. BUG=https://bugs.chromium.org/p/google-breakpad/issues/detail?id=631

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -18 lines)			Patch
M	configure	View	6 chunks	+10 lines, -9 lines	0 comments	Download
M	configure.ac	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/client/linux/crash_generation/crash_generation_server.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/client/linux/dump_writer_common/ucontext_reader.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/client/linux/dump_writer_common/ucontext_reader.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/client/linux/minidump_writer/minidump_writer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/common/linux/dump_symbols.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/common/linux/elf_core_dump.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/common/stabs_reader.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/config.h.in	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Ping? Can someone review this please?

Expand Messages | Collapse Messages