Deprecate --gfe2_reloadable_flag_quic_utils_use_fast_incremental_hash.

net/quic/quic_utils.cc

Index: net/quic/quic_utils.cc
diff --git a/net/quic/quic_utils.cc b/net/quic/quic_utils.cc
index ee0455ba93179157523db34fe194709b055ae07c..2c990226baba783933076c0dae2a1c3d6bed3865 100644
--- a/net/quic/quic_utils.cc
+++ b/net/quic/quic_utils.cc
@@ -56,22 +56,9 @@ uint128 IncrementalHashFast(uint128 uhash, const char* data, size_t len) {
 }
 #endif
 
-uint128 IncrementalHashSlow(uint128 hash, const char* data, size_t len) {
-  // kPrime = 309485009821345068724781371
-  static const uint128 kPrime(16777216, 315);
-  const uint8_t* octets = reinterpret_cast<const uint8_t*>(data);
-  for (size_t i = 0; i < len; ++i) {
-    hash = hash ^ uint128(0, octets[i]);
-    hash = hash * kPrime;
-  }
-  return hash;
-}

[Ryan Hamilton, 2016/02/23 23:40:43]

Since this method is used below, I don't think you want to delete it? If it was
deleted internally, perhaps it needs to be un-deleted :>

[Buck, 2016/02/26 18:54:22]

Done.  Whoops, this was my merge error.  I made a knee jerk response to an
unused function build error.  On closer read, I see the real fix was to apply an
appropriate #ifdef.

-
 uint128 IncrementalHash(uint128 hash, const char* data, size_t len) {
 #ifdef QUIC_UTIL_HAS_UINT128
-  return FLAGS_quic_utils_use_fast_incremental_hash
-             ? IncrementalHashFast(hash, data, len)
-             : IncrementalHashSlow(hash, data, len);
+  return IncrementalHashFast(hash, data, len);
 #else
   return IncrementalHashSlow(hash, data, len);
 #endif