Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 1726113002: Deprecate --gfe2_reloadable_flag_quic_utils_use_fast_incremental_hash. (Closed)

Created:
4 years, 10 months ago by Buck
Modified:
4 years, 10 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, Jeremy Dorfman
Base URL:
https://chromium.googlesource.com/chromium/src.git@114856985
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deprecate --gfe2_reloadable_flag_quic_utils_use_fast_incremental_hash. Merge internal change: 114857101 R=rch@chromium.org BUG=

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix mistake made hand merging #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -20 lines) Patch
M net/quic/quic_flags.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_flags.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/quic_utils.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M net/quic/quic_utils_test.cc View 1 chunk +1 line, -13 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 5 (1 generated)
Buck
4 years, 10 months ago (2016-02-23 22:36:13 UTC) #1
Ryan Hamilton
https://codereview.chromium.org/1726113002/diff/1/net/quic/quic_utils.cc File net/quic/quic_utils.cc (left): https://codereview.chromium.org/1726113002/diff/1/net/quic/quic_utils.cc#oldcode68 net/quic/quic_utils.cc:68: } Since this method is used below, I don't ...
4 years, 10 months ago (2016-02-23 23:40:43 UTC) #3
Buck
https://codereview.chromium.org/1726113002/diff/1/net/quic/quic_utils.cc File net/quic/quic_utils.cc (left): https://codereview.chromium.org/1726113002/diff/1/net/quic/quic_utils.cc#oldcode68 net/quic/quic_utils.cc:68: } On 2016/02/23 23:40:43, Ryan Hamilton wrote: > Since ...
4 years, 10 months ago (2016-02-26 18:54:22 UTC) #4
Ryan Hamilton
4 years, 10 months ago (2016-02-26 19:56:49 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698