src/mips/full-codegen-mips.cc - Issue 17261028: MIPS: Fix stack frame reconstruction for generators with formal arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips/full-codegen-mips.cc

Issue 17261028: MIPS: Fix stack frame reconstruction for generators with formal arguments. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/mips/full-codegen-mips.cc

diff --git a/src/mips/full-codegen-mips.cc b/src/mips/full-codegen-mips.cc

index df83019f15e4a9c349d425da19257592618f3d13..06226ca671d0372a2068bbe055fc7d80c3ace75e 100644

--- a/src/mips/full-codegen-mips.cc

+++ b/src/mips/full-codegen-mips.cc

@@ -2142,7 +2142,7 @@ void FullCodeGenerator::EmitGeneratorResume(Expression *generator,

__ LoadRoot(a2, Heap::kTheHoleValueRootIndex);

Label push_argument_holes, push_frame;

__ bind(&push_argument_holes);

- __ Subu(a3, a3, Operand(1));

+ __ Subu(a3, a3, Operand(Smi::FromInt(1)));

__ Branch(&push_frame, lt, a3, Operand(zero_reg));

__ push(a2);

__ jmp(&push_argument_holes);

« no previous file with comments | « no previous file | no next file » | no next file with comments »