Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(953)

Unified Diff: sdk/lib/io/process.dart

Issue 17261026: Include parent environment by default, add option to not, for Process. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/pub/test/test_pub.dart ('k') | tests/standalone/io/process_environment_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/io/process.dart
diff --git a/sdk/lib/io/process.dart b/sdk/lib/io/process.dart
index 6c79c12d226d86864f553b4823e10f3b03d0ffb5..456d215941a1133c390c6f9f040378cf3be8cca8 100644
--- a/sdk/lib/io/process.dart
+++ b/sdk/lib/io/process.dart
@@ -83,6 +83,10 @@ abstract class Process {
* if an environment variable with code-points outside the US-ASCII range is
* passed in.
*
+ * If [includeParentEnvironment] is `true`, the process's environment will
+ * include the parent process's environment, with [environment] taking
+ * precedence. Default is `true`.
+ *
* If [runInShell] is true, the process will be spawned through a system
* shell. On Linux and Mac OS, [:/bin/sh:] is used, while
* [:%WINDIR%\system32\cmd.exe:] is used on Windows.
@@ -97,6 +101,7 @@ abstract class Process {
List<String> arguments,
{String workingDirectory,
Map<String, String> environment,
+ bool includeParentEnvironment: true,
bool runInShell: false});
/**
@@ -114,6 +119,10 @@ abstract class Process {
* if an environment variable with code-points outside the US-ASCII range is
* passed in.
*
+ * If [includeParentEnvironment] is `true`, the process's environment will
+ * include the parent process's environment, with [environment] taking
+ * precedence. Default is `true`.
+ *
* If [runInShell] is true, the process will be spawned through a system
* shell. On Linux and Mac OS, `/bin/sh` is used, while
* `%WINDIR%\system32\cmd.exe` is used on Windows.
@@ -133,6 +142,7 @@ abstract class Process {
List<String> arguments,
{String workingDirectory,
Map<String, String> environment,
+ bool includeParentEnvironment: true,
bool runInShell: false,
Encoding stdoutEncoding: Encoding.SYSTEM,
Encoding stderrEncoding: Encoding.SYSTEM});
« no previous file with comments | « sdk/lib/_internal/pub/test/test_pub.dart ('k') | tests/standalone/io/process_environment_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698