Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Side by Side Diff: src/hydrogen.cc

Issue 17261023: Remove BinaryOp::result_type (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ast.h ('k') | src/type-info.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 9394 matching lines...) Expand 10 before | Expand all | Expand 10 after
9405 } 9405 }
9406 9406
9407 9407
9408 HInstruction* HOptimizedGraphBuilder::BuildBinaryOperation( 9408 HInstruction* HOptimizedGraphBuilder::BuildBinaryOperation(
9409 BinaryOperation* expr, 9409 BinaryOperation* expr,
9410 HValue* left, 9410 HValue* left,
9411 HValue* right) { 9411 HValue* right) {
9412 HValue* context = environment()->LookupContext(); 9412 HValue* context = environment()->LookupContext();
9413 Handle<Type> left_type = expr->left()->lower_type(); 9413 Handle<Type> left_type = expr->left()->lower_type();
9414 Handle<Type> right_type = expr->right()->lower_type(); 9414 Handle<Type> right_type = expr->right()->lower_type();
9415 Handle<Type> result_type = expr->result_type(); 9415 Handle<Type> result_type = expr->lower_type();
9416 Maybe<int> fixed_right_arg = expr->fixed_right_arg(); 9416 Maybe<int> fixed_right_arg = expr->fixed_right_arg();
9417 Representation left_rep = ToRepresentation(left_type); 9417 Representation left_rep = ToRepresentation(left_type);
9418 Representation right_rep = ToRepresentation(right_type); 9418 Representation right_rep = ToRepresentation(right_type);
9419 Representation result_rep = ToRepresentation(result_type); 9419 Representation result_rep = ToRepresentation(result_type);
9420 if (left_type->Is(Type::None())) { 9420 if (left_type->Is(Type::None())) {
9421 AddSoftDeoptimize(); 9421 AddSoftDeoptimize();
9422 // TODO(rossberg): we should be able to get rid of non-continuous defaults. 9422 // TODO(rossberg): we should be able to get rid of non-continuous defaults.
9423 left_type = handle(Type::Any(), isolate()); 9423 left_type = handle(Type::Any(), isolate());
9424 } 9424 }
9425 if (right_type->Is(Type::None())) { 9425 if (right_type->Is(Type::None())) {
(...skipping 2152 matching lines...) Expand 10 before | Expand all | Expand 10 after
11578 } 11578 }
11579 } 11579 }
11580 11580
11581 #ifdef DEBUG 11581 #ifdef DEBUG
11582 if (graph_ != NULL) graph_->Verify(false); // No full verify. 11582 if (graph_ != NULL) graph_->Verify(false); // No full verify.
11583 if (allocator_ != NULL) allocator_->Verify(); 11583 if (allocator_ != NULL) allocator_->Verify();
11584 #endif 11584 #endif
11585 } 11585 }
11586 11586
11587 } } // namespace v8::internal 11587 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ast.h ('k') | src/type-info.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698