Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Issue 17261019: DevTools: Fix heap snapshot grid misalignment after r152691 (Closed)

Created:
7 years, 6 months ago by alph
Modified:
7 years, 6 months ago
Reviewers:
apavlov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Fix heap snapshot grid misalignment after r152691 r152691 has changed behavior of float items in nowrap containers. Adjust heap snapshot CSS to conform to the new semantics. BUG=248995 R=apavlov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152770

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/devtools/front_end/heapProfiler.css View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
alph
Sasha, could you please take a look.
7 years, 6 months ago (2013-06-20 10:02:27 UTC) #1
apavlov
lgtm
7 years, 6 months ago (2013-06-20 10:51:45 UTC) #2
alph
7 years, 6 months ago (2013-06-20 10:59:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r152770 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698