Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 17261014: Add support to Google Update wrappers for the "automatic updates only" group policy setting. (Closed)

Created:
7 years, 6 months ago by Ryan Myers (chromium)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, grt+watch_chromium.org
Visibility:
Public.

Description

Add support to Google Update wrappers for the "automatic updates only" group policy setting. BUG=251972 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207766

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -8 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/google/google_update_win.h View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/google/google_update_win.cc View 1 1 chunk +7 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/help/version_updater_win.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M chrome/installer/util/google_update_settings.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/installer/util/google_update_settings.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/installer/util/google_update_settings_unittest.cc View 2 chunks +22 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ryan Myers (chromium)
Hey folks -- the exact text of the string's still in UI review, but I'd ...
7 years, 6 months ago (2013-06-20 01:47:30 UTC) #1
Peter Kasting
LGTM https://codereview.chromium.org/17261014/diff/1/chrome/browser/google/google_update_win.cc File chrome/browser/google/google_update_win.cc (right): https://codereview.chromium.org/17261014/diff/1/chrome/browser/google/google_update_win.cc#newcode63 chrome/browser/google/google_update_win.cc:63: if (GoogleUpdateSettings::GetAppUpdatePolicy(app_guid, NULL) == Nit: Cache the result ...
7 years, 6 months ago (2013-06-20 17:55:19 UTC) #2
Ryan Myers (chromium)
Thanks! https://codereview.chromium.org/17261014/diff/1/chrome/browser/google/google_update_win.cc File chrome/browser/google/google_update_win.cc (right): https://codereview.chromium.org/17261014/diff/1/chrome/browser/google/google_update_win.cc#newcode63 chrome/browser/google/google_update_win.cc:63: if (GoogleUpdateSettings::GetAppUpdatePolicy(app_guid, NULL) == On 2013/06/20 17:55:19, Peter ...
7 years, 6 months ago (2013-06-20 19:57:11 UTC) #3
grt (UTC plus 2)
lgtm
7 years, 6 months ago (2013-06-20 22:58:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ryanmyers@chromium.org/17261014/9001
7 years, 6 months ago (2013-06-20 23:01:34 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-21 09:41:21 UTC) #6
Message was sent while issue was closed.
Change committed as 207766

Powered by Google App Engine
This is Rietveld 408576698