Issue 17261013: Change the daemon start type to 'manual' if the host ID has been deleted.

Issue 17261013: Change the daemon start type to 'manual' if the host ID has been deleted. (Closed)

Created:
7 years, 6 months ago by alexeypa (please no reviews)

Modified:
7 years, 6 months ago

Reviewers:
Jamie

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Change the daemon start type to 'manual' if the host ID has been deleted. This will prevent the host from being relaunched every time the machine boots after the host has been deleted remotely. BUG=132626 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207683

Patch Set 1 #

Total comments: 2

Patch Set 2 : CR feedback. #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -20 lines)			Patch
M	remoting/host/daemon_process.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/daemon_process.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/daemon_process_win.cc	View		5 chunks	+54 lines, -0 lines	0 comments	Download
M	remoting/host/desktop_session_win.h	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	remoting/host/desktop_session_win.cc	View		6 chunks	+15 lines, -9 lines	0 comments	Download
M	remoting/host/win/worker_process_launcher.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/win/worker_process_launcher_unittest.cc	View		6 chunks	+6 lines, -6 lines	0 comments	Download
M	remoting/host/worker_process_ipc_delegate.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Jamie

lgtm https://codereview.chromium.org/17261013/diff/1/remoting/host/daemon_process.cc File remoting/host/daemon_process.cc (right): https://codereview.chromium.org/17261013/diff/1/remoting/host/daemon_process.cc#newcode132 remoting/host/daemon_process.cc:132: Nit: I don't think a blank line here ...

7 years, 6 months ago (2013-06-20 17:37:54 UTC) #2

alexeypa (please no reviews)

https://chromiumcodereview.appspot.com/17261013/diff/1/remoting/host/daemon_process.cc File remoting/host/daemon_process.cc (right): https://chromiumcodereview.appspot.com/17261013/diff/1/remoting/host/daemon_process.cc#newcode132 remoting/host/daemon_process.cc:132: On 2013/06/20 17:37:54, Jamie wrote: > Nit: I don't ...

7 years, 6 months ago (2013-06-20 21:19:12 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/17261013/6001

7 years, 6 months ago (2013-06-20 21:19:38 UTC) #4

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=167117

7 years, 6 months ago (2013-06-21 00:20:32 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/17261013/6001

7 years, 6 months ago (2013-06-21 00:46:49 UTC) #6

Message was sent while issue was closed.

Change committed as 207683

Expand Messages | Collapse Messages