Issue 17261009: cc: Make CopyOutputRequests correctly applied from layer space.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17261009: cc: Make CopyOutputRequests correctly applied from layer space. (Closed)

Created:
7 years, 6 months ago by danakj

Modified:
7 years, 6 months ago

Reviewers:
piman

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

cc: Make CopyOutputRequests applied from layer space. The CopyOutputRequest API is on cc::Layer, so the rect it is given should be in layer space. Also add tests for CompositeAndReadback which no longer had any pixel test coverage in cc/ to ensure that its inputs are correctly applied as device viewport space. Tests: LayerTreeHostReadbackDeviceScalePixelTest.ReadbackSubrect_Software LayerTreeHostReadbackDeviceScalePixelTest.ReadbackSubrect_GL LayerTreeHostReadbackDeviceScalePixelTest.ReadbackNonRootLayerSubrect_Software LayerTreeHostReadbackDeviceScalePixelTest.ReadbackNonRootLayerSubrect_GL LayerTreeHostReadbackViaCompositeAndReadbackPixelTest.CompositeAndReadback_Software_1 LayerTreeHostReadbackViaCompositeAndReadbackPixelTest.CompositeAndReadback_Software_2 LayerTreeHostReadbackViaCompositeAndReadbackPixelTest.CompositeAndReadback_GL_1 LayerTreeHostReadbackViaCompositeAndReadbackPixelTest.CompositeAndReadback_GL_2 R=piman BUG=251754 Depends on: https://codereview.chromium.org/17449014/

Patch Set 1 #

Patch Set 2 : copy-request-compositeandreadback: nit #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+445 lines, -9 lines)			Patch
M	cc/cc_tests.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	cc/layers/layer_impl.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	cc/layers/layer_impl.cc	View		1 chunk	+15 lines, -1 line	0 comments	Download
A	cc/test/solid_color_content_layer_client.h	View		1 chunk	+30 lines, -0 lines	0 comments	Download
A	cc/test/solid_color_content_layer_client.cc	View		1 chunk	+29 lines, -0 lines	0 comments	Download
M	cc/trees/layer_tree_host_impl.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	cc/trees/layer_tree_host_pixeltest_readback.cc	View	1	8 chunks	+365 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

danakj

I think I'll just merge this with the last 2 readback CLs to land them ...

7 years, 6 months ago (2013-06-19 21:56:26 UTC) #2

Message was sent while issue was closed.

Merged to https://codereview.chromium.org/17335011/

Expand Messages | Collapse Messages