Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 17261007: [NaCl SDK] .dsc files copy public headers, add ppapi_cpp dev sources (Closed)

Created:
7 years, 6 months ago by binji
Modified:
7 years, 6 months ago
Reviewers:
sbc, Sam Clegg
CC:
chromium-reviews
Visibility:
Public.

Description

[NaCl SDK] .dsc files copy public headers, add ppapi_cpp dev sources The headers were previously copied by build_sdk, but since we already support installing headers from the .dsc files, it seems like a better place to do it. It also forces us to be explicit about the headers/sources we want to include from ppapi_cpp. BUG=250997 R=sbc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207531

Patch Set 1 #

Total comments: 2

Patch Set 2 : don't build host mac yet, it's not necessary #

Patch Set 3 : include mac ppapi host. Also add array/dict dev->stable #

Patch Set 4 : forgot this one #

Patch Set 5 : more sdk_files.list fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+480 lines, -121 lines) Patch
M native_client_sdk/src/build_tools/build_sdk.py View 3 chunks +1 line, -75 lines 0 comments Download
M native_client_sdk/src/build_tools/parse_dsc.py View 1 chunk +3 lines, -2 lines 0 comments Download
M native_client_sdk/src/build_tools/sdk_files.list View 1 2 3 4 3 chunks +42 lines, -5 lines 0 comments Download
M native_client_sdk/src/libraries/ppapi/library.dsc View 1 2 2 chunks +130 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/ppapi_cpp/library.dsc View 1 2 2 chunks +223 lines, -36 lines 0 comments Download
M native_client_sdk/src/libraries/ppapi_cpp_private/library.dsc View 1 2 chunks +35 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/ppapi_gles2/library.dsc View 1 2 chunks +46 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
binji
7 years, 6 months ago (2013-06-19 17:47:35 UTC) #1
Sam Clegg
lgtm https://codereview.chromium.org/17261007/diff/1/native_client_sdk/src/libraries/ppapi/library.dsc File native_client_sdk/src/libraries/ppapi/library.dsc (right): https://codereview.chromium.org/17261007/diff/1/native_client_sdk/src/libraries/ppapi/library.dsc#newcode21 native_client_sdk/src/libraries/ppapi/library.dsc:21: 'pp_array_output.h', Can we put 'ppapi/c/extensions/dev/pp_array_output.h' here here and ...
7 years, 6 months ago (2013-06-19 20:04:44 UTC) #2
binji
https://codereview.chromium.org/17261007/diff/1/native_client_sdk/src/libraries/ppapi/library.dsc File native_client_sdk/src/libraries/ppapi/library.dsc (right): https://codereview.chromium.org/17261007/diff/1/native_client_sdk/src/libraries/ppapi/library.dsc#newcode21 native_client_sdk/src/libraries/ppapi/library.dsc:21: 'pp_array_output.h', On 2013/06/19 20:04:44, Sam Clegg wrote: > Can ...
7 years, 6 months ago (2013-06-19 20:14:33 UTC) #3
Sam Clegg
On 2013/06/19 20:14:33, binji wrote: > https://codereview.chromium.org/17261007/diff/1/native_client_sdk/src/libraries/ppapi/library.dsc > File native_client_sdk/src/libraries/ppapi/library.dsc (right): > > https://codereview.chromium.org/17261007/diff/1/native_client_sdk/src/libraries/ppapi/library.dsc#newcode21 > ...
7 years, 6 months ago (2013-06-19 20:30:42 UTC) #4
binji
7 years, 6 months ago (2013-06-20 20:10:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 manually as r207531 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698