Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 1725983002: Revert of Don't measure CPU time in timing out GPU watchdog. (Closed)

Created:
4 years, 10 months ago by jbauman
Modified:
4 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Don't measure CPU time in timing out GPU watchdog. (patchset #1 id:1 of https://codereview.chromium.org/1711763005/ ) Reason for revert: Too many hangs are caused by slow startup: BUG=589175 Original issue's description: > Don't measure CPU time in timing out GPU watchdog. > > It's possible for the main thread to hang on a GPU event or waiting for the OS, so if CPU usage is required for timing out the watchdog then it's possible it'll never time out. > > Just remove the code that checks for CPU time. Time lost due to suspend/resume events should be handled by the PowerMonitor, and this code seems to work on other platforms without issues. > > BUG=588342 > > Committed: https://crrev.com/ae57b78041762268e1898c165e33b904477433bb > Cr-Commit-Position: refs/heads/master@{#376867} TBR=kbr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=588342 Committed: https://crrev.com/227bc7768e3ee84665b387fa65a01b7b41357218 Cr-Commit-Position: refs/heads/master@{#377076}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -0 lines) Patch
M content/gpu/gpu_watchdog_thread.h View 1 chunk +9 lines, -0 lines 0 comments Download
M content/gpu/gpu_watchdog_thread.cc View 6 chunks +74 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jbauman
Created Revert of Don't measure CPU time in timing out GPU watchdog.
4 years, 10 months ago (2016-02-23 20:30:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1725983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1725983002/1
4 years, 10 months ago (2016-02-23 20:34:49 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-23 20:40:17 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 20:41:35 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/227bc7768e3ee84665b387fa65a01b7b41357218
Cr-Commit-Position: refs/heads/master@{#377076}

Powered by Google App Engine
This is Rietveld 408576698