DevTools: [CSS] Add CSS.editRangeInStyleSheetText() to the protocol

Source/core/inspector/InspectorCSSAgent.cpp

 /*
  * Copyright (C) 2010, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *     notice, this list of conditions and the following disclaimer in the
@@ skipping 810 matching lines @@
     if (!inspectorStyleSheet)
         return;
 
     inspectorStyleSheet->getText(result);
 }
 
 void InspectorCSSAgent::setStyleSheetText(ErrorString* errorString, const String& styleSheetId, const String& text)
 {
     InspectorStyleSheet* inspectorStyleSheet = assertStyleSheetForId(errorString, styleSheetId);
     if (!inspectorStyleSheet) {
-        *errorString = "Style sheet with id " + styleSheetId + " not found.";
+        *errorString = "Style sheet with id " + styleSheetId + " not found";
         return;
     }
 
     TrackExceptionState exceptionState;
     m_domAgent->history()->perform(adoptPtr(new SetStyleSheetTextAction(inspectorStyleSheet, text)), exceptionState);
     *errorString = InspectorDOMAgent::toErrorString(exceptionState);
 }
 
+void InspectorCSSAgent::editRangeInStyleSheetText(ErrorString* errorString, const String& styleSheetId, const RefPtr<JSONObject>& range, const String& text)
+{
+    InspectorStyleSheet* inspectorStyleSheet = assertStyleSheetForId(errorString, styleSheetId);
+    if (!inspectorStyleSheet) {
+        *errorString = "Style sheet with id " + styleSheetId + " not found";

[apavlov, 2014/02/21 14:37:55]

"Stylesheet" ?

[lushnikov, 2014/02/23 16:07:07]

Done.

+        return;
+    }
+    int startLineNumber;
+    int startColumn;
+    int endLineNumber;
+    int endColumn;
+    if (!range->getNumber("startLine", &startLineNumber)) {

[apavlov, 2014/02/21 14:37:55]

This could be extracted:

static bool rangeComponent(ErrorString* errorString, const RefPtr<JSONObject>&
range, const String& component, unsigned& result)
{
    if (!range->getNumber(component, &result) || result < 0) {
        *errorString = component + " must be a non-negative integer";
        return false;
    }
    return true;
}

...

if (!rangeComponent(errorString, range, "startLine", startLineNumber) ||
        !rangeComponent(errorString, range, "startColumn", startColumn) ||
        !rangeComponent(errorString, range, "endLine", endLineNumber) ||
        !rangeComponent(errorString, range, "endColumn", endColumn))
    return;

[lushnikov, 2014/02/23 16:07:07]

Done.

[lushnikov, 2014/02/23 16:07:07]

Done.

+        *errorString = "range.startLine must be an integer value";

[apavlov, 2014/02/21 14:37:55]

"...must be an integer" is sufficient (since "integer" is most commonly used as
a noun)

[lushnikov, 2014/02/23 16:07:07]

Done.

+        return;
+    }
+    if (!range->getNumber("startColumn", &startColumn)) {
+        *errorString = "range.startColumn must be an integer value";
+        return;
+    }
+    if (!range->getNumber("endLine", &endLineNumber)) {
+        *errorString = "range.endLine must be an integer value";
+        return;
+    }
+    if (!range->getNumber("endColumn", &endColumn)) {
+        *errorString = "range.endColumn must be an integer value";
+        return;
+    }
+    if (startLineNumber < 0 || startColumn < 0 || endLineNumber < 0 || endColumn < 0) {
+        *errorString = "Range parameters must be non-negative integer values";
+        return;
+    }
+    String oldText;
+    if (!inspectorStyleSheet->getText(&oldText)) {
+        *errorString = "Failed to fetch stylesheet text";
+        return;
+    }
+
+    unsigned startOffset;
+    unsigned endOffset;
+    bool successConvertion = inspectorStyleSheet->lineNumberAndColumnToOffset(startLineNumber, startColumn, &startOffset);

[apavlov, 2014/02/21 14:37:55]

successConvertion -> success (or something along the lines of
|conversionSuccessful|)

[lushnikov, 2014/02/23 16:07:07]

Done.

+    successConvertion = successConvertion && inspectorStyleSheet->lineNumberAndColumnToOffset(endLineNumber, endColumn, &endOffset);

[apavlov, 2014/02/21 14:37:55]

if (successConversion)
    successConversion = ...

to avoid doing unnecessary work

[lushnikov, 2014/02/23 16:07:07]

This is essentially the same due-to "&&" operation computation short-cutting,
thus no unnecessary work is done.

+    if (!successConvertion || startOffset > oldText.length() || endOffset > oldText.length()) {

[apavlov, 2014/02/21 14:37:55]

it does not make any sense to extract a part of lineNumberAndColumnToOffset()
into here

[lushnikov, 2014/02/23 16:07:07]

Done.

+        *errorString = "Specified range is out of bounds";
+        return;
+    }
+
+    if (startOffset > endOffset) {
+        *errorString = "Range start must preceed its end";

[apavlov, 2014/02/21 14:37:55]

"precede"

or, better yet,

"Range start must not succeed its end", since the range may be empty

[lushnikov, 2014/02/23 16:07:07]

Done.

+        return;
+    }
+
+    oldText.replace(startOffset, endOffset - startOffset, text);
+    setStyleSheetText(errorString, styleSheetId, oldText);
+}
+
 void InspectorCSSAgent::setPropertyText(ErrorString* errorString, const RefPtr<JSONObject>& fullStyleId, int propertyIndex, const String& text, bool overwrite, RefPtr<TypeBuilder::CSS::CSSStyle>& result)
 {
     InspectorCSSId compoundId(fullStyleId);
     ASSERT(!compoundId.isEmpty());
 
     InspectorStyleSheet* inspectorStyleSheet = assertStyleSheetForId(errorString, compoundId.styleSheetId());
     if (!inspectorStyleSheet)
         return;
 
     TrackExceptionState exceptionState;
@@ skipping 470 matching lines @@
             documentsToChange.add(element->ownerDocument());
     }
 
     m_nodeIdToForcedPseudoState.clear();
     for (HashSet<Document*>::iterator it = documentsToChange.begin(), end = documentsToChange.end(); it != end; ++it)
         (*it)->setNeedsStyleRecalc(SubtreeStyleChange);
 }
 
 } // namespace WebCore