DevTools: [CSS] Add CSS.editRangeInStyleSheetText() to the protocol

Source/core/inspector/InspectorCSSAgent.cpp

 /*
  * Copyright (C) 2010, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *     notice, this list of conditions and the following disclaimer in the
@@ skipping 54 matching lines @@
 #include "core/rendering/RenderObject.h"
 #include "core/rendering/RenderText.h"
 #include "core/rendering/RenderTextFragment.h"
 #include "platform/fonts/Font.h"
 #include "platform/fonts/GlyphBuffer.h"
 #include "platform/fonts/WidthIterator.h"
 #include "platform/text/TextRun.h"
 #include "wtf/CurrentTime.h"
 #include "wtf/text/CString.h"
 #include "wtf/text/StringConcatenate.h"
+#include "wtf/text/TextPosition.h"

[apavlov, 2014/02/20 09:58:14]

This should not be here

[lushnikov, 2014/02/20 14:17:04]

Done.

 
 namespace CSSAgentState {
 static const char cssAgentEnabled[] = "cssAgentEnabled";
 }
 
 typedef WebCore::InspectorBackendDispatcher::CSSCommandHandler::EnableCallback EnableCallback;
 
 namespace WebCore {
 
 enum ForcePseudoClassFlags {
@@ skipping 745 matching lines @@
     if (!inspectorStyleSheet) {
         *errorString = "Style sheet with id " + styleSheetId + " not found.";
         return;
     }
 
     TrackExceptionState exceptionState;
     m_domAgent->history()->perform(adoptPtr(new SetStyleSheetTextAction(inspectorStyleSheet, text)), exceptionState);
     *errorString = InspectorDOMAgent::toErrorString(exceptionState);
 }
 
+void InspectorCSSAgent::replaceRangeInStyleSheetText(ErrorString* errorString, const String& styleSheetId, const RefPtr<JSONObject>& range, const String& text)

[apavlov, 2014/02/20 09:58:14]

Is this going to be an undoable operation, like the rest of stylesheet
operations?

[pfeldman, 2014/02/20 11:29:05]

editRangeInStyleSheetText?

[lushnikov, 2014/02/20 14:17:04]

This is essentially a wrapper around setStyleSheetText, so it is undoable out of
the box.

[lushnikov, 2014/02/20 14:17:04]

Done.

+{
+    InspectorStyleSheet* inspectorStyleSheet = assertStyleSheetForId(errorString, styleSheetId);
+    if (!inspectorStyleSheet) {
+        *errorString = "Style sheet with id " + styleSheetId + " not found.";

[apavlov, 2014/02/20 09:58:14]

We have a convention to never place periods at the end of error messages (to
easily handle them in the frontend)

[lushnikov, 2014/02/20 14:17:04]

Done.

+        return;
+    }
+    int startLineNumber;
+    int startColumn;
+    int endLineNumber;
+    int endColumn;
+    if (!range->getNumber("startLine", &startLineNumber)) {
+        *errorString = "range.startLine is not an integer value.";
+        return;
+    }
+    if (!range->getNumber("startColumn", &startColumn)) {
+        *errorString = "range.startColumn is not an integer value.";
+        return;
+    }
+    if (!range->getNumber("endLine", &endLineNumber)) {
+        *errorString = "range.endLine is not an integer value.";
+        return;
+    }
+    if (!range->getNumber("endColumn", &endColumn)) {
+        *errorString = "range.endColumn is not an integer value.";
+        return;
+    }
+    String oldText;
+    if (!inspectorStyleSheet->getText(&oldText)) {
+        *errorString = "Failed to fetch stylesheet text.";
+        return;
+    }
+
+    TextPosition startPosition(OrdinalNumber::fromZeroBasedInt(startLineNumber), OrdinalNumber::fromZeroBasedInt(startColumn));

[apavlov, 2014/02/20 09:58:14]

This code doesn't seem to belong to ICSSAgent (for which you had to open
lineEndings()). Instead, it should be encapsulated into
InspectorStyleSheet::replaceText(...) or similar.

[lushnikov, 2014/02/20 14:17:04]

InspectorStyleSheet soaked all the logic in its lineNumberAndColumnToOffset
method - done.

+    TextPosition endPosition(OrdinalNumber::fromZeroBasedInt(endLineNumber), OrdinalNumber::fromZeroBasedInt(endColumn));
+    OwnPtr<Vector<unsigned> > lineEndings = inspectorStyleSheet->lineEndings();
+    int startOffset = startPosition.toOffsetPosition(*lineEndings.get()).zeroBasedInt();

[apavlov, 2014/02/20 09:58:14]

You don't need .get() here, just (*lineEndings)

[lushnikov, 2014/02/20 14:17:04]

Done.

+    int endOffset = endPosition.toOffsetPosition(*lineEndings.get()).zeroBasedInt();

[apavlov, 2014/02/20 09:58:14]

ditto

[lushnikov, 2014/02/20 14:17:04]

Done.

+    oldText.replace(startOffset, endOffset - startOffset, text);
+    setStyleSheetText(errorString, styleSheetId, oldText);
+}
+
 void InspectorCSSAgent::setPropertyText(ErrorString* errorString, const RefPtr<JSONObject>& fullStyleId, int propertyIndex, const String& text, bool overwrite, RefPtr<TypeBuilder::CSS::CSSStyle>& result)
 {
     InspectorCSSId compoundId(fullStyleId);
     ASSERT(!compoundId.isEmpty());
 
     InspectorStyleSheet* inspectorStyleSheet = assertStyleSheetForId(errorString, compoundId.styleSheetId());
     if (!inspectorStyleSheet)
         return;
 
     TrackExceptionState exceptionState;
@@ skipping 470 matching lines @@
             documentsToChange.add(element->ownerDocument());
     }
 
     m_nodeIdToForcedPseudoState.clear();
     for (HashSet<Document*>::iterator it = documentsToChange.begin(), end = documentsToChange.end(); it != end; ++it)
         (*it)->setNeedsStyleRecalc(SubtreeStyleChange);
 }
 
 } // namespace WebCore