Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1431)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1725913002: Add file hashes to SdkBundle; rename to PackageBundle. (Closed)

Created:
4 years, 10 months ago by Paul Berry
Modified:
4 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add file hashes to SdkBundle; rename to PackageBundle. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/44f507bd05d71e88e06ae3156fc59c36fa42b5b8

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -66 lines) Patch
M pkg/analyzer/lib/src/generated/sdk_io.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.dart View 10 chunks +40 lines, -10 lines 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 2 chunks +40 lines, -33 lines 4 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 5 chunks +25 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summary_sdk.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/tool/summary/build_sdk_summaries.dart View 7 chunks +20 lines, -5 lines 0 comments Download
M pkg/analyzer/tool/summary/stats.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer_cli/lib/src/package_analyzer.dart View 7 chunks +19 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years, 10 months ago (2016-02-23 18:41:54 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1725913002/diff/1/pkg/analyzer/lib/src/summary/idl.dart File pkg/analyzer/lib/src/summary/idl.dart (right): https://codereview.chromium.org/1725913002/diff/1/pkg/analyzer/lib/src/summary/idl.dart#newcode371 pkg/analyzer/lib/src/summary/idl.dart:371: * The list of URIs of items in ...
4 years, 10 months ago (2016-02-23 18:50:18 UTC) #3
Paul Berry
https://codereview.chromium.org/1725913002/diff/1/pkg/analyzer/lib/src/summary/idl.dart File pkg/analyzer/lib/src/summary/idl.dart (right): https://codereview.chromium.org/1725913002/diff/1/pkg/analyzer/lib/src/summary/idl.dart#newcode371 pkg/analyzer/lib/src/summary/idl.dart:371: * The list of URIs of items in [linkedLibraries], ...
4 years, 10 months ago (2016-02-23 18:55:24 UTC) #4
Paul Berry
4 years, 10 months ago (2016-02-23 18:56:31 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
44f507bd05d71e88e06ae3156fc59c36fa42b5b8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698