chrome/browser/ui/views/panels/panel_view.cc - Issue 1725883002: Add KeepAliveStateObserver, add the Restart option

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/panels/panel_view.cc

Issue 1725883002: Add KeepAliveStateObserver, add the Restart option (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@KeepAlive

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/lifetime/keep_alive_types.cc ('K') | « chrome/browser/ui/apps/chrome_app_delegate.cc ('k') | chrome/browser/ui/views/profiles/user_manager_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/panels/panel_view.cc

diff --git a/chrome/browser/ui/views/panels/panel_view.cc b/chrome/browser/ui/views/panels/panel_view.cc

index 5d3f27e3de2a32a899af56a4566fc5f0ea3727bc..748326f48bfe796b9149bb1a7e8acd8d3a175d27 100644

--- a/chrome/browser/ui/views/panels/panel_view.cc

+++ b/chrome/browser/ui/views/panels/panel_view.cc

@@ -304,7 +304,8 @@ PanelView::PanelView(Panel* panel, const gfx::Rect& bounds, bool always_on_top)

#if !defined(OS_CHROMEOS)

// Prevent the browser process from shutting down while this window is open.

// Chrome OS already has a mechanism to always stay alive and skips this.

- keep_alive_.reset(new ScopedKeepAlive(keep_alive::Origin::PANEL_VIEW));

+ keep_alive_.reset(new ScopedKeepAlive(keep_alive::Origin::PANEL_VIEW,

+ keep_alive::RestartOption::DISABLED));

#endif // !defined(OS_CHROMEOS)

web_view_ = new views::WebView(NULL);