chrome/browser/lifetime/keep_alive_options.h - Issue 1725883002: Add KeepAliveStateObserver, add the Restart option

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/lifetime/keep_alive_options.h

Issue 1725883002: Add KeepAliveStateObserver, add the Restart option (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@KeepAlive

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/background/background_mode_manager.cc ('k') | chrome/browser/lifetime/keep_alive_registry.h » ('j') | chrome/browser/lifetime/keep_alive_registry.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/lifetime/keep_alive_options.h

diff --git a/chrome/browser/lifetime/keep_alive_options.h b/chrome/browser/lifetime/keep_alive_options.h

index 8918912e6a0435505fa81e1841e834af42fe7b45..61e11a0175dbeaef1a254374f202cd10c81636b4 100644

--- a/chrome/browser/lifetime/keep_alive_options.h

+++ b/chrome/browser/lifetime/keep_alive_options.h

@@ -5,11 +5,17 @@

#ifndef CHROME_BROWSER_LIFETIME_KEEP_ALIVE_OPTIONS_H_

#define CHROME_BROWSER_LIFETIME_KEEP_ALIVE_OPTIONS_H_

+// Restart: Allow Chrome to restart when all the registered KeepAlives allow

+// restarts

+enum class KeepAliveOptionRestart { DISABLED, ENABLED };

dgn 2016/02/23 16:58:46 Should I have an extra member like UNKNOWN that wo

struct KeepAliveOptions {

// Should be descriptive of what the KeepAlive's lifetime is tied to, to help

// with debugging.

const char* label;

+ const KeepAliveOptionRestart restart;

// TODO(dgn)

// When registering a token, we should add indications of which kind of

// optimizations are allowed during the KeepAlive's lifetime. This will allow