chrome/browser/lifetime/keep_alive_state_observer.h - Issue 1725883002: Add KeepAliveStateObserver, add the Restart option

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/lifetime/keep_alive_state_observer.h

Issue 1725883002: Add KeepAliveStateObserver, add the Restart option (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@KeepAlive

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/lifetime/keep_alive_registry_unittest.cc ('K') | « chrome/browser/lifetime/keep_alive_registry_unittest.cc ('k') | chrome/browser/lifetime/keep_alive_types.h » ('j') | chrome/browser/lifetime/scoped_keep_alive.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_LIFETIME_KEEP_ALIVE_STATE_OBSERVER_H_

	6 #define CHROME_BROWSER_LIFETIME_KEEP_ALIVE_STATE_OBSERVER_H_

	7

	8 #include "base/macros.h"

	9

	10 struct KeepAliveOptions;

	11

	12 class KeepAliveStateObserver {

	13 public:

	14 virtual void OnRestartAllowed() = 0;
	sky 2016/02/26 22:13:25 How about an OnKeepAliveRestartStateChanged(bool c How about an OnKeepAliveRestartStateChanged(bool can_restart); dgn 2016/03/09 16:35:31 Yes done. I started with split methods as my curre Show quoted text On 2016/02/26 22:13:25, sky wrote: > How about an OnKeepAliveRestartStateChanged(bool can_restart); Yes done. I started with split methods as my current implementations of them were very different, but that's a detail in the implementation, and should not be relevant to the interface here.
	15 virtual void OnRestartForbidden() = 0;

	16

	17 protected:

	18 KeepAliveStateObserver() {}
	sky 2016/02/26 22:13:25 nit: I don't think you need this. nit: I don't think you need this. dgn 2016/03/09 16:35:31 Removed. Show quoted text On 2016/02/26 22:13:25, sky wrote: > nit: I don't think you need this. Removed.
	19 virtual ~KeepAliveStateObserver() {}

	20

	21 DISALLOW_COPY_AND_ASSIGN(KeepAliveStateObserver);
	sky 2016/02/26 22:13:25 you shouldn't need this as KeepAliveStateObserver you shouldn't need this as KeepAliveStateObserver has pure virtual functions. dgn 2016/03/09 16:35:31 Done. Show quoted text On 2016/02/26 22:13:25, sky wrote: > you shouldn't need this as KeepAliveStateObserver has pure virtual functions. Done.
	22 };

	23

	24 #endif // CHROME_BROWSER_LIFETIME_KEEP_ALIVE_STATE_OBSERVER_H_

OLD	NEW