Fix PRESUBMIT tests for committed files that are not .md or .html

Fix PRESUBMIT tests for committed files that are not .md or .html

The extensions were being removed before testing, but since only md and html
are considered in the clean urls, the path canonalizer redirects (302) to
the URL with extension. But a 302 of a changed template file is considered a
test fail. Examples that would fail the presubmit tests are images, CSSs,
redirect.json, etc.

BUG=343614
NOTRY=true
R=kalman@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252127

[Renato Mangini (chromium), 2014-02-19 21:13:43]

Ben, this change is required to get Meggin's change on redirects.json, otherwise
tests will fail: a PRESUBMIT test is requesting /redirects.json as /redirects,
which triggers a fail condition. I've changed it to only remove known extensions
(md and html).

[not at google - send to devlin, 2014-02-19 21:16:40]

lgtm with 2 nits. you could use ternary there as well if you prefer.

https://codereview.chromium.org/172573004/diff/1/chrome/common/extensions/PRE...
File chrome/common/extensions/PRESUBMIT.py (right):

https://codereview.chromium.org/172573004/diff/1/chrome/common/extensions/PRE...
chrome/common/extensions/PRESUBMIT.py:28: EXTENSIONS_TO_REMOVE_FOR_CLEAN_URLS =
['.md', '.html']
('.md', '.html') not []

https://codereview.chromium.org/172573004/diff/1/chrome/common/extensions/PRE...
chrome/common/extensions/PRESUBMIT.py:53: (filename, ext) =
os.path.splitext(template)
you can write just filename, ext not (filename, ext)

though filename is not really accurate, it should be like "base" or something.

[Renato Mangini (chromium), 2014-02-19 21:24:46]

The CQ bit was checked by mangini@chromium.org

[commit-bot: I haz the power, 2014-02-19 21:42:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mangini@chromium.org/172573004/60001

[Renato Mangini (chromium), 2014-02-19 22:21:29]

https://codereview.chromium.org/172573004/diff/1/chrome/common/extensions/PRE...
File chrome/common/extensions/PRESUBMIT.py (right):

https://codereview.chromium.org/172573004/diff/1/chrome/common/extensions/PRE...
chrome/common/extensions/PRESUBMIT.py:28: EXTENSIONS_TO_REMOVE_FOR_CLEAN_URLS =
['.md', '.html']
On 2014/02/19 21:16:40, kalman wrote:
> ('.md', '.html') not []

Done.

https://codereview.chromium.org/172573004/diff/1/chrome/common/extensions/PRE...
chrome/common/extensions/PRESUBMIT.py:53: (filename, ext) =
os.path.splitext(template)
On 2014/02/19 21:16:40, kalman wrote:
> you can write just filename, ext not (filename, ext)
> 
> though filename is not really accurate, it should be like "base" or something.

Done.

[Renato Mangini (chromium), 2014-02-19 23:31:49]

The CQ bit was unchecked by mangini@chromium.org

[Renato Mangini (chromium), 2014-02-19 23:31:52]

The CQ bit was checked by mangini@chromium.org

[Renato Mangini (chromium), 2014-02-19 23:55:58]

The CQ bit was unchecked by mangini@chromium.org

[Renato Mangini (chromium), 2014-02-19 23:56:10]

Committed patchset #2 manually as r252127 (presubmit successful).