Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1725643003: Pass ChildProcessCreationParams in ChildProcessLauncher.warmUp (Closed)

Created:
4 years, 10 months ago by mnaganov (inactive)
Modified:
4 years, 10 months ago
CC:
chromium-reviews, davidben+watch_chromium.org, cbentzel+watch_chromium.org, tburkard+watch_chromium.org, jam, gavinp+prer_chromium.org, darin-cc_chromium.org, Benoit L
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass ChildProcessCreationParams in ChildProcessLauncher.warmUp This fixes the use case when Chrome is started via Custom Tabs. BUG=588397 TBR=dtrainor@chromium.org Committed: https://crrev.com/cad57047c680feda55633193eba84cb181e6c1b9 Cr-Commit-Position: refs/heads/master@{#377217}

Patch Set 1 #

Messages

Total messages: 13 (6 generated)
mnaganov (inactive)
Yusuf, PTAL! Tested by building a stable channel Chrome and launching Twitter. I'm not sure ...
4 years, 10 months ago (2016-02-23 02:06:14 UTC) #2
Yusuf
I would ignore PrerenderService as it is deprecated. I should delete that when we have ...
4 years, 10 months ago (2016-02-23 20:10:13 UTC) #3
mnaganov (inactive)
Thanks, Yusuf! David, you reviewed the original change, this is a small addendum to fix ...
4 years, 10 months ago (2016-02-23 21:31:38 UTC) #5
mnaganov (inactive)
Dave has provided his approval over IM and suggested TBRing the change to him. Thanks, ...
4 years, 10 months ago (2016-02-24 02:46:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1725643003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1725643003/1
4 years, 10 months ago (2016-02-24 02:50:21 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-24 04:12:39 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 04:13:30 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cad57047c680feda55633193eba84cb181e6c1b9
Cr-Commit-Position: refs/heads/master@{#377217}

Powered by Google App Engine
This is Rietveld 408576698