Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 172563003: Fix some typo and nits while reading the code. (Closed)

Created:
6 years, 10 months ago by etienneb
Modified:
6 years, 10 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix some typo and nits while reading the code. Removed from this CL: https://codereview.chromium.org/171143002/ R=cpu, dsinclair BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252222

Patch Set 1 #

Patch Set 2 : moar nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M base/debug/trace_event_impl.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M base/win/event_trace_consumer.h View 1 chunk +1 line, -1 line 0 comments Download
M base/win/event_trace_consumer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/win/event_trace_controller.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
etienneb
PTAL, and CQ it.
6 years, 10 months ago (2014-02-19 16:42:46 UTC) #1
dsinclair
lgtm
6 years, 10 months ago (2014-02-19 16:53:11 UTC) #2
etienneb
The CQ bit was checked by etienneb@chromium.org
6 years, 10 months ago (2014-02-19 17:11:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/etienneb@chromium.org/172563003/30001
6 years, 10 months ago (2014-02-19 17:13:05 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 17:21:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 10 months ago (2014-02-19 17:21:52 UTC) #6
etienneb
CPU, need an OWNER. CQ it please.
6 years, 10 months ago (2014-02-19 17:53:24 UTC) #7
cpu_(ooo_6.6-7.5)
lgtm
6 years, 10 months ago (2014-02-19 22:57:30 UTC) #8
cpu_(ooo_6.6-7.5)
The CQ bit was checked by cpu@chromium.org
6 years, 10 months ago (2014-02-19 22:58:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/etienneb@chromium.org/172563003/30001
6 years, 10 months ago (2014-02-19 23:16:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/etienneb@chromium.org/172563003/30001
6 years, 10 months ago (2014-02-20 01:05:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/etienneb@chromium.org/172563003/30001
6 years, 10 months ago (2014-02-20 04:53:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/etienneb@chromium.org/172563003/30001
6 years, 10 months ago (2014-02-20 08:53:46 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/etienneb@chromium.org/172563003/30001
6 years, 10 months ago (2014-02-20 12:22:59 UTC) #14
commit-bot: I haz the power
6 years, 10 months ago (2014-02-20 13:39:07 UTC) #15
Message was sent while issue was closed. 
Change committed as 252222

Powered by Google App Engine
This is Rietveld 408576698