Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1725563004: Files: Add a shortcut Alt-E to open gear menu. (Closed)

Created:
4 years, 10 months ago by fukino
Modified:
4 years, 8 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files: Add a shortcut Alt-E to open gear menu. BUG=308825 TEST=run browser_tests --gtest_filter=*GearMenu* Committed: https://crrev.com/f26fd9e384e1f7e6f77b6da706345f8ba90616b6 Cr-Commit-Position: refs/heads/master@{#376955}

Patch Set 1 #

Total comments: 2

Patch Set 2 : use canExecuteAlways. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -4 lines) Patch
M ui/file_manager/file_manager/foreground/js/file_manager_commands.js View 1 1 chunk +21 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/main.html View 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/integration_tests/file_manager/gear_menu.js View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
fukino
PTAL. Thanks!
4 years, 10 months ago (2016-02-23 07:56:19 UTC) #2
hirono
lgtm with a nit. Thanks! https://codereview.chromium.org/1725563004/diff/1/ui/file_manager/file_manager/foreground/js/file_manager_commands.js File ui/file_manager/file_manager/foreground/js/file_manager_commands.js (right): https://codereview.chromium.org/1725563004/diff/1/ui/file_manager/file_manager/foreground/js/file_manager_commands.js#newcode1481 ui/file_manager/file_manager/foreground/js/file_manager_commands.js:1481: canExecute: function(event, fileManager) { ...
4 years, 10 months ago (2016-02-23 08:41:12 UTC) #3
fukino
https://codereview.chromium.org/1725563004/diff/1/ui/file_manager/file_manager/foreground/js/file_manager_commands.js File ui/file_manager/file_manager/foreground/js/file_manager_commands.js (right): https://codereview.chromium.org/1725563004/diff/1/ui/file_manager/file_manager/foreground/js/file_manager_commands.js#newcode1481 ui/file_manager/file_manager/foreground/js/file_manager_commands.js:1481: canExecute: function(event, fileManager) { On 2016/02/23 08:41:11, hirono wrote: ...
4 years, 10 months ago (2016-02-23 08:50:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1725563004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1725563004/20001
4 years, 10 months ago (2016-02-23 08:51:32 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-23 09:32:20 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/f26fd9e384e1f7e6f77b6da706345f8ba90616b6 Cr-Commit-Position: refs/heads/master@{#376955}
4 years, 10 months ago (2016-02-23 09:33:54 UTC) #10
judykeastwood0217
4 years, 8 months ago (2016-04-02 11:16:28 UTC) #11
Message was sent while issue was closed. 
On 2016/02/23 09:33:54, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/f26fd9e384e1f7e6f77b6da706345f8ba90616b6
> Cr-Commit-Position: refs/heads/master@{#376955}

Powered by Google App Engine
This is Rietveld 408576698