Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3339)

Unified Diff: chrome/browser/resources/md_user_manager/user_manager.js

Issue 1725563003: MD user manager (learn more page, user manager tutorial) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_user_manager/user_manager.js
diff --git a/chrome/browser/resources/md_user_manager/user_manager.js b/chrome/browser/resources/md_user_manager/user_manager.js
index 0661794aa9a9af1231d05c5bdb79594359c86063..7470d873d91555b0eace60268183ef16cfd839ad 100644
--- a/chrome/browser/resources/md_user_manager/user_manager.js
+++ b/chrome/browser/resources/md_user_manager/user_manager.js
@@ -47,7 +47,9 @@ cr.define('cr.ui', function() {
// make sense when displayed as a widget.
document.addEventListener('contextmenu', function(e) {e.preventDefault();});
- // TODO(mahmadi): start the tutorial if the location hash is #tutorial.
+ var hash = window.location.hash;
+ if (hash && hash == '#tutorial')
Dan Beam 2016/02/25 17:22:07 why is this code better than if (window.locatio
Moe 2016/03/02 18:25:52 The check is unnecessary. I agree. I reintroduced
+ document.querySelector('user-manager-tutorial').startTutorial();
};
/**
@@ -109,7 +111,7 @@ cr.define('cr.ui', function() {
* Show the user manager tutorial
*/
Oobe.showUserManagerTutorial = function() {
- // TODO(mahmadi): start the tutorial.
+ document.querySelector('user-manager-tutorial').startTutorial();
};
// Export

Powered by Google App Engine
This is Rietveld 408576698