MD user manager (learn more page, user manager tutorial)

chrome/browser/resources/md_user_manager/user_manager_tutorial.js

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+/**
+ * @fileoverview
+ * 'user-manager-tutorial' is the element that controls the tutorial steps for
+ * the user manager page.
+ *
+ * @element user-manager-tutorial
+ */
+Polymer({
+  is: 'user-manager-tutorial',
+
+  properties: {
+    /**
+     * True if the tutorial is currently showing.

[Dan Beam, 2016/02/25 17:22:07]

this is confusing.  did you mean "hidden" instead of showing?  what about
"Whether this tutorial should be visible." or something?  conversely, you could
reverse this to a property named "showing"

[Moe, 2016/03/02 18:25:53]

Done.

+     * @type {boolean}
+     */
+    hidden: {

[Dan Beam, 2016/02/25 17:22:07]

can you use a different name?

[Moe, 2016/03/02 18:25:53]

In the patch set #2 I've changed this to "hidden_" which is the standard I've
been following elsewhere for private properties.

+      type: Boolean,
+      value: true
+    },
+
+    /**
+     * Current tutorial step, index in the steps array.
+     * @type {number}
+     */
+    currentStep_: {
+      type: Number,
+      value: 0
+    }
+  },
+
+  /** @override */
+  created: function() {
+    this.steps_ = ['yourChrome',
+                   'friends',
+                   'guests',
+                   'complete',
+                   'notYou'];

[Dan Beam, 2016/02/25 17:22:07]

this.steps_ = ['yourChrome', 'friends', 'guests', 'complete', 'notYou'];

[Moe, 2016/03/02 18:25:53]

Done.

+  },
+
+  /**
+   * Determines whether a given step is displaying.
+   * @param {string} currentStep Index of the current step
+   * @param {string} step Name of the given step
+   * @return {boolean}
+   * @private
+   */
+  isStepHidden_: function(currentStep, step) {
+    return this.steps_[currentStep] != step;
+  },
+
+  /**
+   * Navigates to the next step.
+   * @private
+   */
+  next_: function() {
+    var nextStep = this.currentStep_ + 1;
+
+    // The last tutorial step is an information bubble that ends the tutorial.
+    if (nextStep >= this.steps_.length)
+      this.endTutorial_();
+    else
+      this.currentStep_ = nextStep;
+  },
+
+  /**
+   * Handler for the link in the last step. Takes user to the create-profile
+   * page in order to add a new profile.
+   * @param {!Event} event
+   * @private
+   */
+  handleAddUser_: function(event) {
+    this.endTutorial_();
+    // Event is caught by user-manager-pages.
+    this.fire('change-page', {page: 'create-user-page'});
+  },
+
+  /**
+   * Starts the tutorial.
+   */
+  startTutorial: function() {
+    this.currentStep_ = 0;
+    this.hidden = false;
+
+    // If there's only one pod, show the steps to the side of the pod.
+    // Otherwise, center the steps and disable interacting with the pods
+    // while the tutorial is showing.
+    var podRow = /** @type {{focusPod: !function(), pods: !Array}} */

[Dan Beam, 2016/02/25 17:22:07]

you should be casting to the generated polymer element type and depending on the
other element in your compiled_resources2.gyp (so it can get type info)

the transformation done by --polymer_pass is (for example) user-manager-tutorial
-> UserManagerTutorialElement

[Moe, 2016/03/02 18:25:52]

unfortunately 'pod-row' is not a polymer element at the moment. Also the
comments in the source don't seem to be properly formatted for closure compiler
and there's no compiled_resources.gyp or compiled_resources2.gyp for it or its
dependencies.

+        ($('pod-row'));
+
+    if (podRow.pods.length == 1) {
+      this.$.yourChrome.classList.add('single-pod');
+      this.$.complete.classList.add('single-pod');
+    }
+
+    podRow.focusPod();  // No focused pods.
+    $('inner-container').classList.add('disabled');
+  },
+
+  /**
+   * Ends the tutorial.
+   * @private
+   */
+  endTutorial_: function() {
+    $('inner-container').classList.remove('disabled');
+    this.hidden = true;

[Dan Beam, 2016/02/25 17:22:07]

yeah, there's already a .hidden setter on HTMLElement, which is why this is
confusing (you're probably shadowing it)

[Moe, 2016/03/02 18:25:52]

I've renamed this to hidden_

+  }
+});