Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1725553002: Dump DisplayListRasterSource memory (Closed)

Created:
4 years, 10 months ago by ericrk
Modified:
4 years, 10 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Dump DisplayListRasterSource memory This change implements MemoryDumpProvider on DisplayListRasterSource. This dumps the estimated memory usage of the display list based on the existing GetPictureMemoryUsage call. Note that for thread safety, MemoryDumpProviders must be registered/ unregistered on the same thread they dump memory on. This is currently done on the compositor main thread. This CL adds a ThreadChecker to ensure this. BUG=567465 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/83e6b8ebbad5c764903c346d8917b8d35dadb35d Cr-Commit-Position: refs/heads/master@{#377109}

Patch Set 1 #

Patch Set 2 : add missing include for windows build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -4 lines) Patch
M cc/playback/display_list_raster_source.h View 1 5 chunks +13 lines, -2 lines 0 comments Download
M cc/playback/display_list_raster_source.cc View 4 chunks +46 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
ericrk
4 years, 10 months ago (2016-02-22 22:34:06 UTC) #3
enne (OOO)
lgtm
4 years, 10 months ago (2016-02-22 22:39:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1725553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1725553002/20001
4 years, 10 months ago (2016-02-23 20:51:24 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-23 23:15:36 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 23:17:23 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/83e6b8ebbad5c764903c346d8917b8d35dadb35d
Cr-Commit-Position: refs/heads/master@{#377109}

Powered by Google App Engine
This is Rietveld 408576698