Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Issue 1725543002: Add a handler to DM to print out what was running when we crash. (Closed)

Created:
4 years, 10 months ago by mtklein_C
Modified:
4 years, 10 months ago
Reviewers:
tomhudson, mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add a handler to DM to print out what was running when we crash. This is an experiment to see if we can use something like this rather than today's extremely verbose logging. Now, hopefully something crashes. BUG=skia:4978 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1725543002 Committed: https://skia.googlesource.com/skia/+/246ba3a8b488eb1cecb98fa0cd657b62c9801a51

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -5 lines) Patch
M dm/DM.cpp View 6 chunks +30 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1725543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1725543002/1
4 years, 10 months ago (2016-02-22 22:18:06 UTC) #3
mtklein_C
4 years, 10 months ago (2016-02-22 22:31:25 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-22 22:43:43 UTC) #8
mtklein
+Mike. Tom's away.
4 years, 10 months ago (2016-02-23 16:19:46 UTC) #10
reed1
lgtm
4 years, 10 months ago (2016-02-23 18:30:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1725543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1725543002/1
4 years, 10 months ago (2016-02-23 18:38:49 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/246ba3a8b488eb1cecb98fa0cd657b62c9801a51
4 years, 10 months ago (2016-02-23 18:39:39 UTC) #15
tomhudson
4 years, 10 months ago (2016-02-24 13:36:24 UTC) #16
Message was sent while issue was closed.
Thanks for trying this; LGTM.

Powered by Google App Engine
This is Rietveld 408576698