Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 1725383002: [test] Rewrite mjsunit/array-natives-elements to make it pass with Crankshaft. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Rewrite mjsunit/array-natives-elements to make it pass with Crankshaft. There was an eval inside the array_natives_test() which prevented Crankshaft, even tho it's unrelated, and so we always went to TurboFan now, which both decreased test coverage and increased time for stress opt runs. R=machenbach@chromium.org Committed: https://crrev.com/199bfb9b31b22240ba288148cc85bf00ee51ccaa Cr-Commit-Position: refs/heads/master@{#34248}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M test/mjsunit/array-natives-elements.js View 2 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-24 10:46:56 UTC) #1
Michael Achenbach
lgtm - rubber stamp - also adding mvs
4 years, 10 months ago (2016-02-24 10:50:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1725383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1725383002/1
4 years, 10 months ago (2016-02-24 11:53:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-24 11:55:16 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 11:55:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/199bfb9b31b22240ba288148cc85bf00ee51ccaa
Cr-Commit-Position: refs/heads/master@{#34248}

Powered by Google App Engine
This is Rietveld 408576698