Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1173)

Unified Diff: mojo/shell/public/cpp/application_test_base.h

Issue 1725353003: Eliminate mojo::Shell client lib class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@15connector
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/shell/public/cpp/application_test_base.h
diff --git a/mojo/shell/public/cpp/application_test_base.h b/mojo/shell/public/cpp/application_test_base.h
index f8ff6ad9ec0c890f60e1abf444b3c7bc5683b9e8..bba59168f9e3d6f517a4a3128e7b548ff3e72c6a 100644
--- a/mojo/shell/public/cpp/application_test_base.h
+++ b/mojo/shell/public/cpp/application_test_base.h
@@ -9,6 +9,7 @@
#include "mojo/public/cpp/bindings/array.h"
#include "mojo/public/cpp/bindings/string.h"
#include "mojo/public/cpp/system/macros.h"
+#include "mojo/shell/public/cpp/connector.h"
#include "mojo/shell/public/cpp/shell_client.h"
#include "mojo/shell/public/cpp/shell_connection.h"
#include "mojo/shell/public/interfaces/shell_client.mojom.h"
@@ -32,8 +33,8 @@ class TestHelper {
explicit TestHelper(ShellClient* client);
~TestHelper();
- Shell* shell() { return shell_connection_.get(); }
- std::string shell_url() { return url_; }
+ Connector* connector() { return shell_connection_->connector(); }
+ std::string test_url() { return url_; }
private:
// The application delegate used if GetShellClient is not overridden.
@@ -54,11 +55,11 @@ class ApplicationTestBase : public testing::Test {
~ApplicationTestBase() override;
protected:
- Shell* shell() {
- return test_helper_ ? test_helper_->shell() : nullptr;
+ Connector* connector() {
+ return test_helper_ ? test_helper_->connector() : nullptr;
}
- std::string shell_url() const {
- return test_helper_ ? test_helper_->shell_url() : std::string();
+ std::string test_url() const {
+ return test_helper_ ? test_helper_->test_url() : std::string();
}
// Get the ShellClient for the application to be tested.

Powered by Google App Engine
This is Rietveld 408576698