mojo/services/package_manager/package_manager.h - Issue 1725353003: Eliminate mojo::Shell client lib class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/package_manager/package_manager.h

Issue 1725353003: Eliminate mojo::Shell client lib class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@15connector

Patch Set: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/services/package_manager/package_manager.h

diff --git a/mojo/services/package_manager/package_manager.h b/mojo/services/package_manager/package_manager.h

index e587cc610f8fa92ebb1962fa22d4c114b5ebe769..dc36d8e41d02afc4621ff37c0471e792af778926 100644

--- a/mojo/services/package_manager/package_manager.h

+++ b/mojo/services/package_manager/package_manager.h

@@ -14,7 +14,6 @@

#include "mojo/services/package_manager/public/interfaces/resolver.mojom.h"

#include "mojo/services/package_manager/public/interfaces/shell_resolver.mojom.h"

#include "mojo/shell/public/cpp/interface_factory.h"

-#include "mojo/shell/public/cpp/shell.h"

#include "mojo/shell/public/cpp/shell_client.h"

#include "url/gurl.h"

@@ -80,8 +79,6 @@ class PackageManager : public mojo::ShellClient,

using MojoURLAliasMap = std::map<GURL, std::pair<GURL, std::string>>;

// mojo::ShellClient:

- void Initialize(mojo::Shell* shell, const std::string& url,

- uint32_t id, uint32_t user_id) override;

bool AcceptConnection(mojo::Connection* connection) override;

// mojo::InterfaceFactory<mojom::Resolver>: