Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Issue 1725353003: Eliminate mojo::Shell client lib class (Closed)

Created:
4 years, 10 months ago by Ben Goodger (Google)
Modified:
4 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, feature-media-reviews_chromium.org, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@15connector
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace with mojo::Connector (already exists) now that Shell is gone. Requires: - Move AppRefCount to a different class, MessageLoopRef, which is optionally used by applications that wish to quit the current message loop started by application runner when the ref drops to zero. - Changing the signature of Initialize() to take a Connector. This is what most of the change in this CL is. BUG= Committed: https://crrev.com/e4a2bc4fb161d8d2ea673d5f55119d36be2cf06f Cr-Commit-Position: refs/heads/master@{#377841}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Total comments: 1

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : . #

Patch Set 10 : . #

Patch Set 11 : . #

Patch Set 12 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+663 lines, -709 lines) Patch
M ash/mus/keyboard_ui_mus.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M ash/mus/keyboard_ui_mus.cc View 1 2 3 4 5 1 chunk +5 lines, -5 lines 0 comments Download
M ash/mus/shelf_delegate_mus.cc View 1 2 3 4 5 6 7 2 chunks +4 lines, -3 lines 0 comments Download
M ash/mus/sysui_application.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/mus/sysui_application.cc View 1 2 3 4 5 6 7 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/app/mash/mash_runner.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_mus.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M components/bitmap_uploader/bitmap_uploader.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M components/bitmap_uploader/bitmap_uploader.cc View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +3 lines, -3 lines 0 comments Download
M components/filesystem/file_system_app.h View 1 2 3 3 chunks +2 lines, -3 lines 0 comments Download
M components/filesystem/file_system_app.cc View 1 2 3 2 chunks +5 lines, -6 lines 0 comments Download
M components/filesystem/files_test_base.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M components/filesystem/public/cpp/prefs/pref_service_factory.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M components/filesystem/public/cpp/prefs/pref_service_factory.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M components/font_service/font_service_app.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M components/font_service/font_service_app.cc View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -2 lines 0 comments Download
M components/font_service/public/cpp/font_loader.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M components/font_service/public/cpp/font_loader.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M components/leveldb/leveldb_app.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M components/leveldb/leveldb_app.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M components/leveldb/leveldb_apptest.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M components/mus/mus_app.h View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M components/mus/mus_app.cc View 1 2 3 9 chunks +10 lines, -10 lines 0 comments Download
M components/mus/public/cpp/lib/window_tree_client_impl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/lib/window_tree_client_impl.cc View 1 2 3 4 chunks +5 lines, -5 lines 0 comments Download
M components/mus/public/cpp/lib/window_tree_host_factory.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M components/mus/public/cpp/tests/window_server_test_base.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/window_tree_connection.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/window_tree_host_factory.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/ws/display_manager.h View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M components/mus/ws/display_manager.cc View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
M components/mus/ws/display_manager_factory.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/ws/window_manager_client_apptest.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/ws/window_tree_apptest.cc View 1 2 3 8 chunks +8 lines, -8 lines 0 comments Download
M components/mus/ws/window_tree_host_impl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/window_tree_host_impl.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/ws/window_tree_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/resource_provider/public/cpp/resource_loader.h View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M components/resource_provider/public/cpp/resource_loader.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M components/resource_provider/resource_provider_app.h View 1 2 3 4 2 chunks +1 line, -5 lines 0 comments Download
M components/resource_provider/resource_provider_app.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M components/resource_provider/resource_provider_apptest.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_main_loop.cc View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/mojo/mojo_shell_client_host.cc View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mus.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/mojo/mojo_shell_connection_impl.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/mojo/mojo_shell_connection_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/common/mojo_shell_connection.h View 1 2 3 4 5 2 chunks +2 lines, -3 lines 0 comments Download
M content/public/test/test_mojo_app.h View 1 2 3 2 chunks +0 lines, -5 lines 0 comments Download
M content/public/test/test_mojo_app.cc View 1 2 3 4 5 6 2 chunks +4 lines, -9 lines 0 comments Download
M content/renderer/mus/render_widget_mus_connection.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M mash/browser_driver/browser_driver_application_delegate.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M mash/browser_driver/browser_driver_application_delegate.cc View 1 2 3 4 chunks +6 lines, -6 lines 0 comments Download
M mash/example/views_examples/views_examples_application_delegate.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M mash/example/views_examples/views_examples_application_delegate.cc View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M mash/example/window_type_launcher/window_type_launcher.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M mash/example/window_type_launcher/window_type_launcher.cc View 1 2 3 5 chunks +10 lines, -9 lines 0 comments Download
M mash/quick_launch/quick_launch_application.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M mash/quick_launch/quick_launch_application.cc View 1 2 3 5 chunks +10 lines, -10 lines 0 comments Download
M mash/screenlock/screenlock.h View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M mash/screenlock/screenlock.cc View 1 2 3 5 chunks +14 lines, -15 lines 0 comments Download
M mash/shell/shell_application_delegate.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M mash/shell/shell_application_delegate.cc View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M mash/task_viewer/task_viewer.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M mash/task_viewer/task_viewer.cc View 1 2 3 5 chunks +11 lines, -12 lines 0 comments Download
M mash/wm/accelerator_registrar_apptest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M mash/wm/non_client_frame_controller.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M mash/wm/non_client_frame_controller.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M mash/wm/root_window_controller.h View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +2 lines, -2 lines 0 comments Download
M mash/wm/root_window_controller.cc View 1 2 3 4 5 6 7 8 9 10 11 4 chunks +5 lines, -5 lines 0 comments Download
M mash/wm/window_manager.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M mash/wm/window_manager_application.h View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M mash/wm/window_manager_application.cc View 1 2 3 4 chunks +7 lines, -7 lines 0 comments Download
M mash/wm/window_manager_apptest.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M media/mojo/services/media_apptest.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/mojo_media_application.h View 1 2 3 3 chunks +5 lines, -3 lines 0 comments Download
M media/mojo/services/mojo_media_application.cc View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M media/mojo/services/service_factory_impl.h View 1 2 3 4 5 6 3 chunks +5 lines, -4 lines 0 comments Download
M media/mojo/services/service_factory_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/test/pipeline_integration_test.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/versioning_apptest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/network/cookie_store_impl.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/services/network/cookie_store_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/http_server_apptest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/http_server_impl.h View 1 4 chunks +4 lines, -4 lines 0 comments Download
M mojo/services/network/http_server_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/network/network_service_delegate.h View 1 4 chunks +9 lines, -4 lines 0 comments Download
M mojo/services/network/network_service_delegate.cc View 1 2 4 chunks +18 lines, -20 lines 0 comments Download
M mojo/services/network/network_service_impl.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/services/network/network_service_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/tcp_bound_socket_impl.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/services/network/tcp_bound_socket_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/tcp_connected_socket_impl.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/services/network/tcp_connected_socket_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/tcp_server_socket_impl.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/services/network/tcp_server_socket_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/udp_socket_apptest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/udp_socket_impl.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/services/network/udp_socket_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/url_loader_factory_impl.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/services/network/url_loader_factory_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/url_loader_impl.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/services/network/url_loader_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/url_loader_impl_apptest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/services/network/web_socket_factory_impl.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/services/network/web_socket_factory_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/web_socket_impl.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/services/network/web_socket_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/package_manager/package_manager.h View 1 2 3 4 2 chunks +0 lines, -3 lines 0 comments Download
M mojo/services/package_manager/package_manager.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/services/test_service/test_request_tracker_application.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/test_service/test_request_tracker_application.cc View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M mojo/services/test_service/test_service_application.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/test_service/test_service_application.cc View 1 2 chunks +6 lines, -5 lines 0 comments Download
M mojo/services/test_service/test_service_impl.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/services/test_service/test_service_impl.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M mojo/services/test_service/test_time_service_impl.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/services/test_service/test_time_service_impl.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/services/tracing/public/cpp/tracing_impl.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/tracing/public/cpp/tracing_impl.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/services/tracing/tracing_app.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/tracing/tracing_app.cc View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/shell/background/tests/background_shell_unittest.cc View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/shell/background/tests/test_service.cc View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download
M mojo/shell/public/cpp/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/shell/public/cpp/application_test_base.h View 1 2 3 chunks +7 lines, -6 lines 0 comments Download
A mojo/shell/public/cpp/lib/message_loop_ref.cc View 1 2 1 chunk +98 lines, -0 lines 0 comments Download
M mojo/shell/public/cpp/lib/shell_client.cc View 1 2 chunks +1 line, -3 lines 0 comments Download
M mojo/shell/public/cpp/lib/shell_connection.cc View 1 6 chunks +3 lines, -111 lines 0 comments Download
A mojo/shell/public/cpp/message_loop_ref.h View 1 2 1 chunk +57 lines, -0 lines 0 comments Download
M mojo/shell/public/cpp/shell.h View 1 1 chunk +1 line, -57 lines 0 comments Download
M mojo/shell/public/cpp/shell_client.h View 1 3 chunks +3 lines, -13 lines 0 comments Download
M mojo/shell/public/cpp/shell_connection.h View 1 2 4 chunks +3 lines, -20 lines 0 comments Download
M mojo/shell/runner/child/native_apptest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/runner/child/native_apptest_target.cc View 1 2 3 4 2 chunks +0 lines, -3 lines 0 comments Download
M mojo/shell/tests/application_manager_apptest.cc View 1 2 3 4 4 chunks +3 lines, -5 lines 0 comments Download
M mojo/shell/tests/application_manager_apptest_driver.cc View 1 2 3 4 4 chunks +5 lines, -8 lines 0 comments Download
M mojo/shell/tests/application_manager_apptest_target.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/tests/application_manager_unittest.cc View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M mojo/shell/tests/capability_filter_test.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/tests/capability_filter_test.cc View 1 2 3 4 4 chunks +9 lines, -10 lines 0 comments Download
M mojo/shell/tests/package_apptest.cc View 1 2 3 3 chunks +5 lines, -3 lines 0 comments Download
M mojo/shell/tests/package_test_package.cc View 1 2 3 4 5 6 7 8 9 7 chunks +14 lines, -12 lines 0 comments Download
M ui/views/mus/aura_init.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/mus/aura_init.cc View 1 2 3 4 chunks +6 lines, -6 lines 0 comments Download
M ui/views/mus/native_widget_mus.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/mus/native_widget_mus.cc View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/mus/platform_test_helper_mus.cc View 1 2 3 4 5 6 2 chunks +4 lines, -3 lines 0 comments Download
M ui/views/mus/platform_window_mus.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/mus/platform_window_mus.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/mus/screen_mus.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/mus/screen_mus.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/mus/surface_binding.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/mus/surface_binding.cc View 1 2 3 8 chunks +12 lines, -11 lines 0 comments Download
M ui/views/mus/surface_context_factory.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/mus/surface_context_factory.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/mus/window_manager_connection.h View 1 2 3 4 chunks +5 lines, -5 lines 0 comments Download
M ui/views/mus/window_manager_connection.cc View 1 2 3 3 chunks +8 lines, -8 lines 0 comments Download
M ui/views/mus/window_tree_host_mus.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/mus/window_tree_host_mus.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 35 (20 generated)
Ben Goodger (Google)
The interesting parts to look at are in mojo/shell, the rest you can just scan ...
4 years, 10 months ago (2016-02-25 19:20:16 UTC) #3
sky
LGTM https://codereview.chromium.org/1725353003/diff/100001/mojo/shell/public/cpp/message_loop_ref.h File mojo/shell/public/cpp/message_loop_ref.h (right): https://codereview.chromium.org/1725353003/diff/100001/mojo/shell/public/cpp/message_loop_ref.h#newcode5 mojo/shell/public/cpp/message_loop_ref.h:5: #ifndef MOJO_SHELL_PUBLIC_CPP_APPLICATION_RUNNER_REFERENCE_H_ nit: guards are wrong.
4 years, 10 months ago (2016-02-25 20:30:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1725353003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1725353003/120001
4 years, 10 months ago (2016-02-26 00:33:41 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/27528) android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, ...
4 years, 10 months ago (2016-02-26 00:53:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1725353003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1725353003/140001
4 years, 10 months ago (2016-02-26 00:54:25 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/136072) linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 10 months ago (2016-02-26 01:24:20 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1725353003/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1725353003/160001
4 years, 10 months ago (2016-02-26 02:33:20 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/187499)
4 years, 10 months ago (2016-02-26 03:01:56 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1725353003/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1725353003/180001
4 years, 10 months ago (2016-02-26 03:09:13 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/149204)
4 years, 10 months ago (2016-02-26 03:47:00 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1725353003/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1725353003/200001
4 years, 10 months ago (2016-02-26 06:00:47 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/136754) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 10 months ago (2016-02-26 06:05:44 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1725353003/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1725353003/220001
4 years, 10 months ago (2016-02-26 06:10:30 UTC) #31
commit-bot: I haz the power
Committed patchset #12 (id:220001)
4 years, 10 months ago (2016-02-26 07:30:35 UTC) #33
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 07:31:48 UTC) #35
Message was sent while issue was closed.
Patchset 12 (id:??) landed as
https://crrev.com/e4a2bc4fb161d8d2ea673d5f55119d36be2cf06f
Cr-Commit-Position: refs/heads/master@{#377841}

Powered by Google App Engine
This is Rietveld 408576698