Issue 172533002: MIPS: Harmony: optimize Math.clz32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 172533002: MIPS: Harmony: optimize Math.clz32. (Closed)

Created:
6 years, 10 months ago by kilvadyb

Modified:
6 years, 10 months ago

Reviewers:
Yang, Jakob Kummerow, Paul Lind, danno, kisg, palfia, dusmil

CC:
v8-dev

Base URL:
git@github.com:paul99/v8m-rb.git@master

Visibility:
Public.

More Reviews

Description

MIPS: Harmony: optimize Math.clz32. Port r19487 (bd8c70f) BUG=v8:2938 LOG=N

Patch Set 2 : Fixed nit. #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -0 lines)			Patch
M	src/mips/lithium-codegen-mips.cc	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/mips/lithium-mips.h	View		3 chunks	+14 lines, -0 lines	0 comments	Download
M	src/mips/lithium-mips.cc	View		2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

dusmil

https://codereview.chromium.org/172533002/diff/1/src/mips/lithium-codegen-mips.cc File src/mips/lithium-codegen-mips.cc (right): https://codereview.chromium.org/172533002/diff/1/src/mips/lithium-codegen-mips.cc#newcode3802 src/mips/lithium-codegen-mips.cc:3802: __ clz(result, input); Use Clz from macro-assembler for compatibility.

6 years, 10 months ago (2014-02-19 16:10:25 UTC) #2

kilvadyb

6 years, 10 months ago (2014-02-19 16:59:25 UTC) #3

Committed as r19499.

Expand Messages | Collapse Messages

Issue 172533002: MIPS: Harmony: optimize Math.clz32. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fixed nit. #

Messages