core/src/fpdfapi/fpdf_page/pageint.h - Issue 1725303003: Fix static initializers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_page/pageint.h

Issue 1725303003: Fix static initializers. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: back to static local Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_page/pageint.h

diff --git a/core/src/fpdfapi/fpdf_page/pageint.h b/core/src/fpdfapi/fpdf_page/pageint.h

index a36b848bcaa2c284940308d9368b512bc4d835d8..ec06187b6c4abcb3693d680a883f2d6aeffbcb03 100644

--- a/core/src/fpdfapi/fpdf_page/pageint.h

+++ b/core/src/fpdfapi/fpdf_page/pageint.h

@@ -154,7 +154,7 @@ class CPDF_StreamContentParser {

protected:

using OpCodes =

std::unordered_map<FX_DWORD, void (CPDF_StreamContentParser::*)()>;

- static const OpCodes s_OpCodes;

Tom Sepez 2016/02/25 01:28:08 Sure you don't want to just make this a pointer?

Lei Zhang 2016/02/25 19:19:33 Static local variables are initialized only on fir

+ static OpCodes InitializeOpCodes();

void Handle_CloseFillStrokePath();

void Handle_FillStrokePath();