Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1725303003: Fix static initializers. (Closed)

Created:
4 years, 10 months ago by Lei Zhang
Modified:
4 years, 10 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : back to static local #

Total comments: 2

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -116 lines) Patch
M core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 1 2 2 chunks +122 lines, -106 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/pageint.h View 1 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/fpdfxfa/fpdfxfa_util.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfxfa/fpdfxfa_util.cpp View 3 chunks +16 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Lei Zhang
I should have checked with dump-static-initializers.py yesterday.
4 years, 10 months ago (2016-02-25 00:23:12 UTC) #2
Tom Sepez
https://codereview.chromium.org/1725303003/diff/20001/core/src/fpdfapi/fpdf_page/pageint.h File core/src/fpdfapi/fpdf_page/pageint.h (left): https://codereview.chromium.org/1725303003/diff/20001/core/src/fpdfapi/fpdf_page/pageint.h#oldcode157 core/src/fpdfapi/fpdf_page/pageint.h:157: static const OpCodes s_OpCodes; Sure you don't want to ...
4 years, 10 months ago (2016-02-25 01:28:09 UTC) #3
Lei Zhang
https://codereview.chromium.org/1725303003/diff/20001/core/src/fpdfapi/fpdf_page/pageint.h File core/src/fpdfapi/fpdf_page/pageint.h (left): https://codereview.chromium.org/1725303003/diff/20001/core/src/fpdfapi/fpdf_page/pageint.h#oldcode157 core/src/fpdfapi/fpdf_page/pageint.h:157: static const OpCodes s_OpCodes; On 2016/02/25 01:28:08, Tom Sepez ...
4 years, 10 months ago (2016-02-25 19:19:33 UTC) #4
Tom Sepez
lgtm
4 years, 10 months ago (2016-02-25 22:23:55 UTC) #5
Lei Zhang
4 years, 10 months ago (2016-02-25 22:42:32 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
104fa7c879398c67cdaab3f7064ca9f6da07b072 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698