Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: java/org/chromium/distiller/DomUtil.java

Issue 1725243002: Fix some warnings in Eclipse (Closed) Base URL: git@github.com:chromium/dom-distiller.git@master
Patch Set: rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: java/org/chromium/distiller/DomUtil.java
diff --git a/java/org/chromium/distiller/DomUtil.java b/java/org/chromium/distiller/DomUtil.java
index 27690c4b482ef8aad7bc815ea79ed12ad2a6607d..6f829322f90bfe67a949e8eaee91b2dd50e0128e 100644
--- a/java/org/chromium/distiller/DomUtil.java
+++ b/java/org/chromium/distiller/DomUtil.java
@@ -311,7 +311,7 @@ public class DomUtil {
/**
* Only keep some attributes for image elements.
- * @param ie The image element to strip in-place.
+ * @param imgElement The image element to strip in-place.
*/
public static void stripImageElement(ImageElement imgElement) {
JsArray<Node> attrs = getAttributes(imgElement);
@@ -352,6 +352,7 @@ public class DomUtil {
* Strips some attribute from certain tags in the tree rooted at |rootNode|, including root.
* @param tagNames The tag names to be processed. ["*"] means all.
*/
+ @SuppressWarnings("unused")
mdjones 2016/02/24 22:24:35 Any idea why this is needed? The usages are in non
wychen 2016/05/10 22:26:37 It's tag in tagNames. Eclipse doesn't recognize ta
public static void stripAttributeFromTags(Node rootNode, String attribute, String[] tagNames) {
Element root = Element.as(rootNode);
for (String tag: tagNames) {

Powered by Google App Engine
This is Rietveld 408576698