src/ast.cc - Issue 172523002: Create a function call IC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast.cc

Issue 172523002: Create a function call IC (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Comments addressed. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ast.cc

diff --git a/src/ast.cc b/src/ast.cc

index 6b2f48f0172b9bea33bcc7457ce7425d26963eab..979d1b9a7d8b65ea4f319bc81e8f1abb66e940a8 100644

--- a/src/ast.cc

+++ b/src/ast.cc

@@ -595,12 +595,11 @@ void Expression::RecordToBooleanTypeFeedback(TypeFeedbackOracle* oracle) {

int Call::ComputeFeedbackSlotCount(Isolate* isolate) {

CallType call_type = GetCallType(isolate);

- if (call_type == LOOKUP_SLOT_CALL || call_type == OTHER_CALL) {

- // Call only uses a slot in some cases.

- return 1;

+ if (call_type == POSSIBLY_EVAL_CALL) {

+ return 0;

}

- return 0;

+ return 1;

}