Create a function call IC

src/ic.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 24 matching lines @@
 
 
 const int kMaxKeyedPolymorphism = 4;
 
 
 // IC_UTIL_LIST defines all utility functions called from generated
 // inline caching code. The argument for the macro, ICU, is the function name.
 #define IC_UTIL_LIST(ICU)                             \
   ICU(LoadIC_Miss)                                    \
   ICU(KeyedLoadIC_Miss)                               \
+  ICU(CallIC_Miss)                                    \
   ICU(StoreIC_Miss)                                   \
   ICU(StoreIC_ArrayLength)                            \
   ICU(StoreIC_Slow)                                   \
   ICU(SharedStoreIC_ExtendStorage)                    \
   ICU(KeyedStoreIC_Miss)                              \
   ICU(KeyedStoreIC_Slow)                              \
   /* Utilities for IC stubs. */                       \
   ICU(StoreCallbackProperty)                          \
   ICU(LoadPropertyWithInterceptorOnly)                \
   ICU(LoadPropertyWithInterceptorForLoad)             \
@@ skipping 49 matching lines @@
   static void Clear(Isolate* isolate, Address address);
 
 #ifdef DEBUG
   bool IsLoadStub() const {
     return target()->is_load_stub() || target()->is_keyed_load_stub();
   }
 
   bool IsStoreStub() const {
     return target()->is_store_stub() || target()->is_keyed_store_stub();
   }
+
+  bool IsCallStub() const {
+    return target()->is_call_stub();
+  }
 #endif
 
   // Determines which map must be used for keeping the code stub.
   // These methods should not be called with undefined or null.
   static inline InlineCacheHolderFlag GetCodeCacheForObject(Object* object);
   // TODO(verwaest): This currently returns a HeapObject rather than JSObject*
   // since loading the IC for loading the length from strings are stored on
   // the string map directly, rather than on the JSObject-typed prototype.
   static inline HeapObject* GetCodeCacheHolder(Isolate* isolate,
                                                Object* object,
@@ skipping 149 matching lines @@
 
   Address address() const { return address_; }
 
   IC::UtilityId id() const { return id_; }
  private:
   Address address_;
   IC::UtilityId id_;
 };
 
 
+class CallIC: public IC {
+ public:
+  class State V8_FINAL BASE_EMBEDDED {
+   public:
+    explicit State(ExtraICState extra_ic_state);
+
+    State(int argc,
+          bool call_as_method,
+          bool monomorphic = false,
+          bool args_match = true,
+          bool strict_native = false)
+        : argc_(argc),
+        call_as_method_(call_as_method),
+        monomorphic_(monomorphic),
+        args_match_(args_match),
+        strict_native_(strict_native) {
+    }
+
+    InlineCacheState GetICState() const {
+      return monomorphic_
+          ? ::v8::internal::MONOMORPHIC
+          : ::v8::internal::GENERIC;
+    }
+
+    ExtraICState GetExtraICState() const;
+
+    static int ExtractArgcFromMinorKey(int minor_key) {

[Toon Verwaest, 2014/03/10 13:50:44]

minor key -> ExtraICState? Only code stubs have major / minor keys. The rest of
the IC mechanism talks about extra IC state (which is encoded in the code flags,
independent of where the minor / major stuff is encoded).

+      return ArgBits::decode(minor_key);
+    }
+
+    static void GenerateAheadOfTime(
+        Isolate*, void (*Generate)(Isolate*, const State&));
+
+    int arg_count() const { return argc_; }
+    bool call_as_method() const { return call_as_method_; }
+    bool monomorphic() const { return monomorphic_; }
+    bool args_match() const { return args_match_; }
+    bool strict_native() const { return strict_native_; }
+
+    void Print(StringStream* stream) const;
+
+   private:
+    STATIC_ASSERT(Code::kArgumentsBits == 16);

[Toon Verwaest, 2014/03/10 13:50:44]

What about just using kArgumentsBits in the counts below so we don't need to
change it by hand later?

[mvstanton, 2014/03/20 15:51:53]

Done.

+    class ArgBits: public BitField<int, 0, 16> {};
+    class CallAsMethodBits: public BitField<bool, 16, 1> {};
+    class MonomorphicBits: public BitField<bool, 17, 1> {};
+    class ArgsMatchBits: public BitField<bool, 18, 1> {};
+    class StrictNativeBits: public BitField<bool, 19, 1> {};
+    // We have a few extra bits.

[Toon Verwaest, 2014/03/10 13:50:44]

Not sure how many you have left. Aren't these encoded in ExtraICStateField?
That's only 20 bits isn't it?

[mvstanton, 2014/03/20 15:51:53]

Old comment, removed.

+
+    int argc_;
+    bool call_as_method_;
+    bool monomorphic_;
+    bool args_match_;
+    bool strict_native_;
+  };
+
+  explicit CallIC(Isolate* isolate)
+      : IC(EXTRA_CALL_FRAME, isolate) {
+  }
+
+  void HandleMiss(Handle<Object> receiver,
+                  Handle<Object> function,
+                  Handle<FixedArray> vector,
+                  Handle<Smi> slot);
+
+  // Code generator routines.
+  static void GenerateNormal(MacroAssembler* masm, int argc,
+                             bool call_as_method);
+  static Handle<Code> initialize_stub(Isolate* isolate,
+                                      int argc,
+                                      bool call_as_method);
+
+  static void Clear(Address address, Code* target);
+
+ private:
+  void PatchMegamorphic(int arg_count, bool call_as_method);
+};
+
+
 class LoadIC: public IC {
  public:
   // ExtraICState bits
   class ContextualModeBits: public BitField<ContextualMode, 0, 1> {};
   STATIC_ASSERT(static_cast<int>(NOT_CONTEXTUAL) == 0);
 
   static ExtraICState ComputeExtraICState(ContextualMode contextual_mode) {
     return ContextualModeBits::encode(contextual_mode);
   }
 
@@ skipping 597 matching lines @@
 DECLARE_RUNTIME_FUNCTION(MaybeObject*, ElementsTransitionAndStoreIC_Miss);
 DECLARE_RUNTIME_FUNCTION(MaybeObject*, BinaryOpIC_Miss);
 DECLARE_RUNTIME_FUNCTION(MaybeObject*, BinaryOpIC_MissWithAllocationSite);
 DECLARE_RUNTIME_FUNCTION(MaybeObject*, CompareNilIC_Miss);
 DECLARE_RUNTIME_FUNCTION(MaybeObject*, ToBooleanIC_Miss);
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_IC_H_