Create a function call IC

src/code-stubs.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 34 matching lines @@
   V(BinaryOpICWithAllocationSite)        \
   V(BinaryOpWithAllocationSite)          \
   V(StringAdd)                           \
   V(SubString)                           \
   V(StringCompare)                       \
   V(Compare)                             \
   V(CompareIC)                           \
   V(CompareNilIC)                        \
   V(MathPow)                             \
   V(StringLength)                        \
+  V(CallIC)                              \
   V(FunctionPrototype)                   \
   V(StoreArrayLength)                    \
   V(RecordWrite)                         \
   V(StoreBufferOverflow)                 \
   V(RegExpExec)                          \
   V(Instanceof)                          \
   V(ConvertToDouble)                     \
   V(WriteInt32ToHeapNumber)              \
   V(StackCheck)                          \
   V(Interrupt)                           \
@@ skipping 752 matching lines @@
 
   virtual int MinorKey() {
     return KindBits::encode(kind_);
   }
 
  private:
   Code::Kind kind_;
 };
 
 
+class CallICStub: public PlatformCodeStub {
+ public:
+  explicit CallICStub(const CallIC::State& state)
+      : state_(state) {}
+
+  int arg_count() const { return state_.arg_count(); }
+  bool call_as_method() const { return state_.call_as_method(); }
+  bool monomorphic() const { return state_.monomorphic(); }
+  bool args_match() const { return state_.args_match(); }
+  bool strict_native() const { return state_.strict_native(); }

[Toon Verwaest, 2014/03/10 13:50:44]

is_strict_or_native?

[mvstanton, 2014/03/20 15:51:53]

The move to enums addressed this satisfactorily I think.

+
+  static int ExtractArgcFromMinorKey(int minor_key) {
+    return CallIC::State::ExtractArgcFromMinorKey(minor_key);
+  }
+
+  virtual void Generate(MacroAssembler* masm);
+
+  virtual Code::Kind GetCodeKind() const V8_OVERRIDE {
+    return Code::CALL_IC;
+  }
+
+  virtual InlineCacheState GetICState() V8_FINAL V8_OVERRIDE {
+    return state_.GetICState();
+  }
+
+  virtual ExtraICState GetExtraICState() V8_FINAL V8_OVERRIDE {
+    return state_.GetExtraICState();
+  }
+
+  static void GenerateAheadOfTime(Isolate* isolate);
+
+ protected:
+  virtual int MinorKey() { return GetExtraICState(); }
+  virtual void PrintState(StringStream* stream) V8_FINAL V8_OVERRIDE;
+
+ private:
+  virtual CodeStub::Major MajorKey() { return CallIC; }
+
+  // Code generation helpers.
+  void GenerateCall(MacroAssembler* masm, bool monomorphic,
+                    bool args_match, bool strict_or_native);
+  void GenerateMiss(MacroAssembler* masm);
+
+  CallIC::State state_;
+};
+
+
 class FunctionPrototypeStub: public ICStub {
  public:
   explicit FunctionPrototypeStub(Code::Kind kind) : ICStub(kind) { }
   virtual void Generate(MacroAssembler* masm);
 
  private:
   virtual CodeStub::Major MajorKey() { return FunctionPrototype; }
 };
 
 
@@ skipping 742 matching lines @@
   static const int kInput = 2;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(RegExpConstructResultStub);
 };
 
 
 class CallFunctionStub: public PlatformCodeStub {
  public:
   CallFunctionStub(int argc, CallFunctionFlags flags)
-      : argc_(argc), flags_(flags) { }
+      : argc_(argc), flags_(flags) {
+    // CallFunctionStub no longer supports RECORD_CALL_TARGET.
+    ASSERT(flags != RECORD_CALL_TARGET);
+  }
 
   void Generate(MacroAssembler* masm);
 
   virtual void FinishCode(Handle<Code> code) {
     code->set_has_function_cache(RecordCallTarget());
   }
 
   static int ExtractArgcFromMinorKey(int minor_key) {
     return ArgcBits::decode(minor_key);
   }
@@ skipping 877 matching lines @@
 
 
 class CallDescriptors {
  public:
   static void InitializeForIsolate(Isolate* isolate);
 };
 
 } }  // namespace v8::internal
 
 #endif  // V8_CODE_STUBS_H_