Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 1725203002: Stage ES2015 iterator finalization (Closed)

Created:
4 years, 10 months ago by Dan Ehrenberg
Modified:
4 years, 10 months ago
Reviewers:
rossberg
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Stage ES2015 iterator finalization This patch moves for-of closing to staging. There are a couple of minor semantics bugs remaining in finalization along edge cases, but we don't know of any stability issues. BUG=v8:3566 R=rossberg LOG=Y Committed: https://crrev.com/cc6d938444ca2f7484cd370ff61cd6e3a7720c40 Cr-Commit-Position: refs/heads/master@{#34254}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -15 lines) Patch
M src/flag-definitions.h View 2 chunks +1 line, -1 line 0 comments Download
M test/test262/test262.status View 2 chunks +2 lines, -14 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1725203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1725203002/1
4 years, 10 months ago (2016-02-24 03:09:44 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-24 04:07:59 UTC) #4
Dan Ehrenberg
4 years, 10 months ago (2016-02-24 04:19:59 UTC) #5
rossberg
lgtm, thanks.
4 years, 10 months ago (2016-02-24 11:25:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1725203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1725203002/1
4 years, 10 months ago (2016-02-24 16:19:09 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-24 16:20:38 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 16:21:01 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc6d938444ca2f7484cd370ff61cd6e3a7720c40
Cr-Commit-Position: refs/heads/master@{#34254}

Powered by Google App Engine
This is Rietveld 408576698