Issue 172513002: Rename PageGroupLoadDeferrer to ScopedPageLoadDeferrer

Issue 172513002: Rename PageGroupLoadDeferrer to ScopedPageLoadDeferrer (Closed)

Created:
6 years, 10 months ago by kenneth.r.christiansen

Modified:
6 years, 10 months ago

Reviewers:
apavlov, jochen (gone - plz use gerrit)

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Rename PageGroupLoadDeferrer to ScopedPageLoadDeferrer In Chrome there is only one page group consisting of all normal pages, and we are in the process of getting rid of PageGroup. The new name makes it clear that the guard is scoped, and the ctor is changed so that it optionally takes a page as argument which will not be deferred. Updated all call sites and simplified them a bit. The class is also simplified slightly given the new argument. BUG=288249 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167457

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -177 lines)			Patch
M	Source/core/core.gypi	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/page/Chrome.cpp	View	7 chunks	+11 lines, -8 lines	0 comments	Download
M	Source/core/page/EventSource.h	View	1 chunk	+1 line, -1 line	0 comments	Download
D	Source/core/page/PageGroupLoadDeferrer.h	View	1 chunk	+0 lines, -42 lines	0 comments	Download
D	Source/core/page/PageGroupLoadDeferrer.cpp	View	1 chunk	+0 lines, -77 lines	0 comments	Download
A +	Source/core/page/ScopedPageLoadDeferrer.h	View	1 chunk	+15 lines, -14 lines	0 comments	Download
A +	Source/core/page/ScopedPageLoadDeferrer.cpp	View	3 chunks	+19 lines, -20 lines	0 comments	Download
M	Source/web/WebViewImpl.cpp	View	3 chunks	+7 lines, -13 lines	0 comments	Download