Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 1725123006: Add checked_cast to avoid Windows compiler errors (Closed)

Created:
4 years, 10 months ago by jrummell
Modified:
4 years, 10 months ago
Reviewers:
kcc2, DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add checked_cast to avoid Windows compiler errors BUG=589852 TEST=compiles Committed: https://crrev.com/7137af07ab066ab99a5d216f3c06583af2ba765c Cr-Commit-Position: refs/heads/master@{#377748}

Patch Set 1 #

Patch Set 2 : add //base dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M media/base/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M media/base/container_names_fuzzertest.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
jrummell
PTAL. No idea why 2 weeks later it's not compiling on Windows 64-bit.
4 years, 10 months ago (2016-02-25 19:02:13 UTC) #2
DaleCurtis
Not sure you want checked_cast here. I don't know what size of data the fuzzer ...
4 years, 10 months ago (2016-02-25 19:06:58 UTC) #4
DaleCurtis
offline John mentioned the max size is 10k, so lgtm
4 years, 10 months ago (2016-02-25 19:33:16 UTC) #5
jrummell
For a component build, need to add dependency to //base.
4 years, 10 months ago (2016-02-25 22:39:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1725123006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1725123006/20001
4 years, 10 months ago (2016-02-25 23:33:00 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-26 01:18:45 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 01:19:54 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7137af07ab066ab99a5d216f3c06583af2ba765c
Cr-Commit-Position: refs/heads/master@{#377748}

Powered by Google App Engine
This is Rietveld 408576698