Passing in a Data Reduction Proxy Delegate from Cronet with Data Reduction Proxy Enabled

Passing in a Data Reduction Proxy Delegate from Cronet with Data Reduction Proxy Enabled

The Cronet test,
CronetUrlRequestContextTest#testDataReductionProxyEnabled
started to fail as a result of
https://codereview.chromium.org/1680893002
This fix creates a DataReductionProxyDelegate for Cronet
when built with the data_reduction build flag.

The test relied on having
DataReductionProxyNetworkDelegate handle the
proxy resolution before, but that work is now
handled by DataReductionProxyDelegate.

BUG=589600
Committed: https://crrev.com/4e254a6cef98f089a02123d32a22672b3e900aa7
Cr-Commit-Position: refs/heads/master@{#378337}

[RyanSturm, 2016-02-24 20:41:06]

ryansturm@chromium.org changed reviewers:
+ bengr@chromium.org

[RyanSturm, 2016-02-24 20:41:07]

Fixing Cronet test:
https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Dat...

[RyanSturm, 2016-02-24 20:41:09]

Fixing Cronet test:
https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Dat...

[bengr, 2016-02-26 22:27:06]

lgtm. Please update the CL description to have a one line title and a one
paragraph summary of the change.

[RyanSturm, 2016-02-26 23:03:46]

ryansturm@chromium.org changed reviewers:
+ mef@chromium.org

[RyanSturm, 2016-02-26 23:03:46]

+mef@ as reviewer

[mef, 2016-02-29 15:38:57]

lgtm

https://codereview.chromium.org/1725123005/diff/20001/components/cronet/andro...
File components/cronet/android/cronet_data_reduction_proxy.h (right):

https://codereview.chromium.org/1725123005/diff/20001/components/cronet/andro...
components/cronet/android/cronet_data_reduction_proxy.h:61:
scoped_ptr<net::ProxyDelegate> CreateProxyDelegate();
could you add a comment?

[RyanSturm, 2016-02-29 18:21:44]

Description was changed from

==========
Passing in a Data Reduction Proxy Delegate from Cronet with Data Reduction Proxy
Enabled

BUG=589600
==========

to

==========
Passing in a Data Reduction Proxy Delegate from Cronet with Data Reduction Proxy
Enabled

The Cronet test,
CronetUrlRequestContextTest#testDataReductionProxyEnabled
started to fail as a result of
https://codereview.chromium.org/1680893002
This fix creates a DataReductionProxyDelegate for Cronet
when built with the data_reduction build flag.

The test relied on having
DataReductionProxyNetworkDelegate handle the
proxy resolution before, but that work is now
handled by DataReductionProxyDelegate.

BUG=589600
==========

[RyanSturm, 2016-02-29 18:57:38]

On 2016/02/29 15:38:57, mef wrote:
> lgtm
> 
>
https://codereview.chromium.org/1725123005/diff/20001/components/cronet/andro...
> File components/cronet/android/cronet_data_reduction_proxy.h (right):
> 
>
https://codereview.chromium.org/1725123005/diff/20001/components/cronet/andro...
> components/cronet/android/cronet_data_reduction_proxy.h:61:
> scoped_ptr<net::ProxyDelegate> CreateProxyDelegate();
> could you add a comment?

Added a comment for CreateProxyDelegate

[RyanSturm, 2016-02-29 22:30:45]

The CQ bit was checked by ryansturm@chromium.org

[RyanSturm, 2016-02-29 22:30:46]

The patchset sent to the CQ was uploaded after l-g-t-m from bengr@chromium.org,
mef@chromium.org
Link to the patchset: https://codereview.chromium.org/1725123005/#ps40001
(title: "Adding a comment")

[commit-bot: I haz the power, 2016-02-29 22:31:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1725123005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1725123005/40001

[commit-bot: I haz the power, 2016-03-01 00:13:28]

Description was changed from

==========
Passing in a Data Reduction Proxy Delegate from Cronet with Data Reduction Proxy
Enabled

The Cronet test,
CronetUrlRequestContextTest#testDataReductionProxyEnabled
started to fail as a result of
https://codereview.chromium.org/1680893002
This fix creates a DataReductionProxyDelegate for Cronet
when built with the data_reduction build flag.

The test relied on having
DataReductionProxyNetworkDelegate handle the
proxy resolution before, but that work is now
handled by DataReductionProxyDelegate.

BUG=589600
==========

to

==========
Passing in a Data Reduction Proxy Delegate from Cronet with Data Reduction Proxy
Enabled

The Cronet test,
CronetUrlRequestContextTest#testDataReductionProxyEnabled
started to fail as a result of
https://codereview.chromium.org/1680893002
This fix creates a DataReductionProxyDelegate for Cronet
when built with the data_reduction build flag.

The test relied on having
DataReductionProxyNetworkDelegate handle the
proxy resolution before, but that work is now
handled by DataReductionProxyDelegate.

BUG=589600
==========

[commit-bot: I haz the power, 2016-03-01 00:13:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-01 00:15:48]

Description was changed from

==========
Passing in a Data Reduction Proxy Delegate from Cronet with Data Reduction Proxy
Enabled

The Cronet test,
CronetUrlRequestContextTest#testDataReductionProxyEnabled
started to fail as a result of
https://codereview.chromium.org/1680893002
This fix creates a DataReductionProxyDelegate for Cronet
when built with the data_reduction build flag.

The test relied on having
DataReductionProxyNetworkDelegate handle the
proxy resolution before, but that work is now
handled by DataReductionProxyDelegate.

BUG=589600
==========

to

==========
Passing in a Data Reduction Proxy Delegate from Cronet with Data Reduction Proxy
Enabled

The Cronet test,
CronetUrlRequestContextTest#testDataReductionProxyEnabled
started to fail as a result of
https://codereview.chromium.org/1680893002
This fix creates a DataReductionProxyDelegate for Cronet
when built with the data_reduction build flag.

The test relied on having
DataReductionProxyNetworkDelegate handle the
proxy resolution before, but that work is now
handled by DataReductionProxyDelegate.

BUG=589600

Committed: https://crrev.com/4e254a6cef98f089a02123d32a22672b3e900aa7
Cr-Commit-Position: refs/heads/master@{#378337}
==========

[commit-bot: I haz the power, 2016-03-01 00:15:49]

Patchset 3 (id:??) landed as
https://crrev.com/4e254a6cef98f089a02123d32a22672b3e900aa7
Cr-Commit-Position: refs/heads/master@{#378337}