Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1725123002: Mojo bindings environment: remove usage in gles2. (Closed)

Created:
4 years, 10 months ago by yzshen1
Modified:
4 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo bindings environment: remove usage in gles2. BUG=585942 Committed: https://crrev.com/67adb0d1a11573b9d0bd4fbe144f5e979327009d Cr-Commit-Position: refs/heads/master@{#377314}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -36 lines) Patch
M components/bitmap_uploader/bitmap_uploader.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/mus/public/cpp/lib/context_provider.cc View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/gles2/command_buffer_client_impl.h View 2 chunks +0 lines, -3 lines 0 comments Download
M mojo/gles2/command_buffer_client_impl.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M mojo/gles2/gles2_context.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/gles2/gles2_context.cc View 1 chunk +1 line, -5 lines 0 comments Download
M mojo/gles2/gles2_impl.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M mojo/public/c/gles2/gles2.h View 2 chunks +4 lines, -6 lines 0 comments Download
M mojo/public/platform/native/gles2_thunks.h View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/public/platform/native/gles2_thunks.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
yzshen1
Hi, Scott. Would you please take a look? Thanks!
4 years, 10 months ago (2016-02-24 00:58:04 UTC) #2
sky
LGTM
4 years, 10 months ago (2016-02-24 17:13:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1725123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1725123002/1
4 years, 10 months ago (2016-02-24 17:23:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-24 17:38:32 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/67adb0d1a11573b9d0bd4fbe144f5e979327009d Cr-Commit-Position: refs/heads/master@{#377314}
4 years, 10 months ago (2016-02-24 17:39:51 UTC) #8
Anand Mistry (off Chromium)
On 2016/02/24 17:39:51, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years, 10 months ago (2016-02-26 00:50:06 UTC) #9
yzshen1
4 years, 10 months ago (2016-02-26 05:11:25 UTC) #10
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1732373003/ by yzshen@chromium.org.

The reason for reverting is: This causes crashes:
https://bugs.chromium.org/p/chromium/issues/detail?id=589964

The shell and the application belong to different modules, so they have
different MessageLoop::current() / MessagePumpMojo::current() / etc. Although
these values are in thread-local storage, we refer to them using global
variables which are different in different modules..

Powered by Google App Engine
This is Rietveld 408576698