Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Issue 1725103002: Do gyp_dart after downloading from cloud storage (Closed)

Created:
4 years, 10 months ago by Harry Terkelsen
Modified:
4 years, 10 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M DEPS View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Harry Terkelsen
4 years, 10 months ago (2016-02-24 00:32:19 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years, 10 months ago (2016-02-24 00:43:16 UTC) #3
Ivan Posva
LGTM Thanks, -Ivan
4 years, 10 months ago (2016-02-24 15:27:18 UTC) #5
Siggi Cherem (dart-lang)
Committed patchset #1 (id:1) manually as 90cba79eb568c674127701be860d5df7bb864aa9 (presubmit successful).
4 years, 10 months ago (2016-02-24 20:10:49 UTC) #7
Siggi Cherem (dart-lang)
(landing on behalf of harry who now is ooo)
4 years, 10 months ago (2016-02-24 20:11:14 UTC) #8
Bill Hesse
4 years, 10 months ago (2016-02-25 09:09:04 UTC) #9
Message was sent while issue was closed.
On 2016/02/24 20:11:14, Siggi Cherem (dart-lang) wrote:
> (landing on behalf of harry who now is ooo)

Thanks!

Powered by Google App Engine
This is Rietveld 408576698