Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1725063002: Update Windows Font Fallback (Closed)

Created:
4 years, 10 months ago by eae
Modified:
4 years, 10 months ago
Reviewers:
jschuh
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, vmpstr+blinkwatch_chromium.org, dshwang, jbroman, Justin Novosad, blink-reviews-platform-graphics_chromium.org, Rik, Stephen Chennney, blink-reviews, f(malita), danakj+watch_chromium.org, kinuko+watch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Windows Font Fallback Update the per-script font fallback list on Windows to take advantage of of new and/or updated fonts in Windows 8, 8.1, and 10. This adds support for a quite a few new scripts, on Windows 8 and 10, and updates the list to prefer the newer font where available. R=jschuh@chromium.org BUG=526354, 569928, 382294, 237050 TEST=fast/text/font-fallback.html Committed: https://crrev.com/dae4f571013eea2668b7b573fee387dedd1d3756 Cr-Commit-Position: refs/heads/master@{#377359}

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : Added tests #

Patch Set 4 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -93 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 5 chunks +9 lines, -5 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/font-fallback.html View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/win/FontFallbackWin.cpp View 1 2 chunks +180 lines, -88 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
eae
Found a number of missing and out of date script entries so decided to rebuild ...
4 years, 10 months ago (2016-02-24 00:23:27 UTC) #4
jschuh
rubberstamp lgtm (since I assume you know the lists waaaaay better than me)
4 years, 10 months ago (2016-02-24 18:13:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1725063002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1725063002/80001
4 years, 10 months ago (2016-02-24 18:44:46 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 10 months ago (2016-02-24 20:11:48 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 20:13:21 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/dae4f571013eea2668b7b573fee387dedd1d3756
Cr-Commit-Position: refs/heads/master@{#377359}

Powered by Google App Engine
This is Rietveld 408576698